[
https://issues.apache.org/jira/browse/BEAM-6144?focusedWorklogId=172450&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-172450
]
ASF GitHub Bot logged work on BEAM-6144:
----------------------------------------
Author: ASF GitHub Bot
Created on: 05/Dec/18 18:58
Start Date: 05/Dec/18 18:58
Worklog Time Spent: 10m
Work Description: aaltay commented on a change in pull request #7149:
[BEAM-6144] Add support for the autoscaling flags to the GO SDK.
URL: https://github.com/apache/beam/pull/7149#discussion_r239194436
##########
File path: sdks/go/pkg/beam/runners/dataflow/dataflowlib/job.go
##########
@@ -140,6 +144,18 @@ func Translate(p *pb.Pipeline, opts *JobOptions,
workerURL, jarURL, modelURL str
if opts.NumWorkers > 0 {
job.Environment.WorkerPools[0].NumWorkers = opts.NumWorkers
}
+ if opts.Algorithm != "" {
+ settings := &df.AutoscalingSettings{
+ Algorithm: map[string]string{
+ "NONE":
"AUTOSCALING_ALGORITHM_NONE",
+ "THROUGHPUT_BASED":
"AUTOSCALING_ALGORITHM_BASIC",
+ }[opts.Algorithm],
+ }
+ if opts.MaxNumWorkers > 0 {
Review comment:
`MaxNumWorkers` could be set even if `opts.Algorithm` is not set. If
Algorithm is not set, Dataflow will choose the appropriate autoscaling
algortihm and max num workers would still be used for that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 172450)
Time Spent: 20m (was: 10m)
> Add support for the autoscalingAlgorithm flag
> ---------------------------------------------
>
> Key: BEAM-6144
> URL: https://issues.apache.org/jira/browse/BEAM-6144
> Project: Beam
> Issue Type: Improvement
> Components: sdk-go
> Reporter: Andrew Brampton
> Assignee: Robert Burke
> Priority: Minor
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The go SDK does not support the --autoscalingAlgorithm and --maxNumWorkers
> flags, like the Java and Python SDKs. Add support for this.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
