[
https://issues.apache.org/jira/browse/BEAM-6181?focusedWorklogId=172530&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-172530
]
ASF GitHub Bot logged work on BEAM-6181:
----------------------------------------
Author: ASF GitHub Bot
Created on: 06/Dec/18 00:03
Start Date: 06/Dec/18 00:03
Worklog Time Spent: 10m
Work Description: Ardagan commented on a change in pull request #7202:
[BEAM-6181] Reporting user counters via MonitoringInfos in Portable Dataflow
Runner.
URL: https://github.com/apache/beam/pull/7202#discussion_r239285290
##########
File path:
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/fn/control/BeamFnMapTaskExecutor.java
##########
@@ -307,10 +344,17 @@ void updateProgress() {
grpcWriteOperation.abortWait();
}
- BeamFnApi.Metrics metrics =
MoreFutures.get(bundleProcessOperation.getMetrics());
+ //TODO: Replace getProcessBundleProgress with getMonitoringInfos when
Metrics is deprecated.
Review comment:
I was thinking on the proper way here and assumed that todo that explains
when the code gets deprecated was the best approach.
1. Creating JIRA that looks like "Cleanup Dataflow Runner Harness" when
Metrics are deprecated. Doesn't cover proper workload. So it is not the best
idea in my opinion.
2. Assigning username is not beneficial as well, since we do not know when
will we completely deprecate Metrics. So it doesn't really differ from regular
todo.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 172530)
Time Spent: 3h 20m (was: 3h 10m)
> Utilize MetricInfo for reporting user metrics in Portable Dataflow Java
> Runner.
> -------------------------------------------------------------------------------
>
> Key: BEAM-6181
> URL: https://issues.apache.org/jira/browse/BEAM-6181
> Project: Beam
> Issue Type: Bug
> Components: java-fn-execution
> Reporter: Mikhail Gryzykhin
> Assignee: Mikhail Gryzykhin
> Priority: Major
> Time Spent: 3h 20m
> Remaining Estimate: 0h
>
> New approach to report metrics in FnApi is to utilize MetricInfo structures.
> This approach is implemented in Python SDK and work is ongoing in Java SDK.
> This tasks includes plumbing User metrics reported via MetricInfos through
> Dataflow Java Runner.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
