[ https://issues.apache.org/jira/browse/BEAM-6167?focusedWorklogId=172624&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-172624 ]
ASF GitHub Bot logged work on BEAM-6167: ---------------------------------------- Author: ASF GitHub Bot Created on: 06/Dec/18 11:11 Start Date: 06/Dec/18 11:11 Worklog Time Spent: 10m Work Description: lcaggio commented on a change in pull request #7193: [BEAM-6167] Add class ReadFromTextWithFilename (Python) URL: https://github.com/apache/beam/pull/7193#discussion_r239413466 ########## File path: sdks/python/apache_beam/io/textio.py ########## @@ -383,7 +389,7 @@ def open(self, temp_path): if self._header is not None: file_handle.write(self._header) if self._append_trailing_newlines: - file_handle.write(b'\n') + file_handle.write('\n') Review comment: done ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 172624) Time Spent: 1h (was: 50m) > Create a Class to read content of a file keeping track of the file path > (python) > -------------------------------------------------------------------------------- > > Key: BEAM-6167 > URL: https://issues.apache.org/jira/browse/BEAM-6167 > Project: Beam > Issue Type: Improvement > Components: io-ideas > Affects Versions: 2.8.0 > Reporter: Lorenzo Caggioni > Assignee: Eugene Kirpichov > Priority: Minor > Fix For: Not applicable > > Time Spent: 1h > Remaining Estimate: 0h > > Add a class to read content of a file keeping track of the file path each > element come from. > This is an improvement of the current python/apache_beam/io/textio.py -- This message was sent by Atlassian JIRA (v7.6.3#76005)