[ https://issues.apache.org/jira/browse/BEAM-6138?focusedWorklogId=173064&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-173064 ]
ASF GitHub Bot logged work on BEAM-6138: ---------------------------------------- Author: ASF GitHub Bot Created on: 07/Dec/18 21:11 Start Date: 07/Dec/18 21:11 Worklog Time Spent: 10m Work Description: ajamato commented on a change in pull request #6799: [BEAM-6138] Add User Counter Metric Support to Java SDK URL: https://github.com/apache/beam/pull/6799#discussion_r239947381 ########## File path: model/fn-execution/src/main/proto/beam_fn_api.proto ########## @@ -302,6 +302,97 @@ message ProcessBundleProgressRequest { string instruction_reference = 1; } +// A specification containing required set of fields and labels required +// to be set on a MonitoringInfo for the specific URN for SDK->RunnerHarness +// ProcessBundleResponse reporting. +message MonitoringInfoSpec { + string urn = 1; + string type_urn = 2; + // The list of required + repeated string required_labels = 3; + // Extra non functional parts of the spec for descriptive purposes. + // i.e. description, units, etc. + repeated Annotation annotations = 4; +} + +// Enum extension to store the MonitoringInfoSpecs. +extend google.protobuf.EnumValueOptions { + MonitoringInfoSpec monitoring_info_spec = 207174266; Review comment: I believe that we should use the commit number, and converted it from hex to dec. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 173064) Time Spent: 1.5h (was: 1h 20m) > Add User Metric Support to Java SDK > ----------------------------------- > > Key: BEAM-6138 > URL: https://issues.apache.org/jira/browse/BEAM-6138 > Project: Beam > Issue Type: New Feature > Components: java-fn-execution > Reporter: Alex Amato > Assignee: Alex Amato > Priority: Major > Time Spent: 1.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.3#76005)