[
https://issues.apache.org/jira/browse/BEAM-4678?focusedWorklogId=173597&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-173597
]
ASF GitHub Bot logged work on BEAM-4678:
----------------------------------------
Author: ASF GitHub Bot
Created on: 10/Dec/18 14:09
Start Date: 10/Dec/18 14:09
Worklog Time Spent: 10m
Work Description: robertwb commented on a change in pull request #7228:
[BEAM-4678] Support combiner lifting in portable Flink runner.
URL: https://github.com/apache/beam/pull/7228#discussion_r240222452
##########
File path:
sdks/python/apache_beam/runners/portability/fn_api_runner_transforms.py
##########
@@ -251,18 +278,18 @@ def make_stage(base_stage, transform):
unique_name=transform.unique_name + '/Merge',
spec=beam_runner_api_pb2.FunctionSpec(
urn=common_urns.combine_components
- .COMBINE_MERGE_ACCUMULATORS.urn,
+ .COMBINE_PER_KEY_MERGE_ACCUMULATORS.urn,
payload=transform.spec.payload),
inputs={'in': grouped_pcoll_id},
outputs={'out': merged_pcoll_id}))
yield make_stage(
stage,
beam_runner_api_pb2.PTransform(
- unique_name=transform.unique_name + '/ExtractOutputs',
+ unique_name=transform.unique_name + '/ExtractOutputsX',
Review comment:
Oh, no, just leftover debugging.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 173597)
Time Spent: 1h (was: 50m)
> Support portable combiner lifting in Java Flink Runner
> ------------------------------------------------------
>
> Key: BEAM-4678
> URL: https://issues.apache.org/jira/browse/BEAM-4678
> Project: Beam
> Issue Type: Sub-task
> Components: runner-flink
> Reporter: Daniel Oliveira
> Assignee: Daniel Oliveira
> Priority: Major
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Adjust Flink Runner to support portable combiner lifting as described in the
> following doc:
> https://s.apache.org/beam-runner-api-combine-model
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
