[ https://issues.apache.org/jira/browse/BEAM-6172?focusedWorklogId=174035&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-174035 ]
ASF GitHub Bot logged work on BEAM-6172: ---------------------------------------- Author: ASF GitHub Bot Created on: 11/Dec/18 11:36 Start Date: 11/Dec/18 11:36 Worklog Time Spent: 10m Work Description: mxm commented on issue #7207: [BEAM-6172] Adjust Flink metric names / Add metric reporting tests URL: https://github.com/apache/beam/pull/7207#issuecomment-446171930 Merging this, Python PreCommit failures unrelated. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 174035) Time Spent: 2h 20m (was: 2h 10m) > Flink metrics are not generated in standard format > -------------------------------------------------- > > Key: BEAM-6172 > URL: https://issues.apache.org/jira/browse/BEAM-6172 > Project: Beam > Issue Type: Improvement > Components: runner-flink > Affects Versions: 2.8.0 > Reporter: Micah Wylde > Assignee: Maximilian Michels > Priority: Minor > Time Spent: 2h 20m > Remaining Estimate: 0h > > The metrics that the flink runner exports do not follow the standard format > used by Flink, and doesn't respect Flink metric configuration options. > For example (with the default metrics configuration) beam produces a metric: > {code} > 10-100-209-71.taskmanager.0f29b420b63fea58f6f321bc0cbf45f3.BeamApp-mwylde-1203224439-a7d8fdf6.group.0.__counter__group__org-apache-beam-runners-core-ReduceFnRunner__droppedDueToClosedWindow > {code} > whereas a native Flink metric looks like: > {code} > 10-100-209-71.taskmanager.0f29b420b63fea58f6f321bc0cbf45f3.BeamApp-mwylde-1203224439-a7d8fdf6.Source-Custom-Source-7Kinesis-None-beam-env-docker-v1-0-ToKeyedWorkItem.0.numRecordsOut > {code} > In particular, Beam should respect the > [metric.scope.delimiter|https://ci.apache.org/projects/flink/flink-docs-release-1.5/ops/config.html#metrics-scope-delimiter] > configuration for separating components of a metric (currently it uses > "__"), and should not include the type of metric (counter, gauge, etc.). -- This message was sent by Atlassian JIRA (v7.6.3#76005)