[ 
https://issues.apache.org/jira/browse/BEAM-5191?focusedWorklogId=178128&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-178128
 ]

ASF GitHub Bot logged work on BEAM-5191:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 21/Dec/18 19:49
            Start Date: 21/Dec/18 19:49
    Worklog Time Spent: 10m 
      Work Description: chamikaramj commented on a change in pull request 
#7061: [BEAM-5191] Support for BigQuery clustering
URL: https://github.com/apache/beam/pull/7061#discussion_r243669333
 
 

 ##########
 File path: 
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryIO.java
 ##########
 @@ -1646,6 +1676,11 @@ public WriteResult expand(PCollection<T> input) {
             "The supplied getTableFunction object can directly set 
TimePartitioning."
                 + " There is no need to call 
BigQueryIO.Write.withTimePartitioning.");
       }
+      if (getJsonClustering() != null) {
+        checkArgument(
+            getJsonTimePartitioning() != null,
 
 Review comment:
   So that combinations (getJsonClustering and getTimePartitioning) and 
(getClustering and getJsonTimePartitioning) are not accepted ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 178128)
    Time Spent: 1h  (was: 50m)

> Add support for writing to BigQuery clustered tables
> ----------------------------------------------------
>
>                 Key: BEAM-5191
>                 URL: https://issues.apache.org/jira/browse/BEAM-5191
>             Project: Beam
>          Issue Type: Improvement
>          Components: io-java-gcp
>    Affects Versions: 2.6.0
>            Reporter: Robert Sahlin
>            Assignee: Wout Scheepers
>            Priority: Minor
>              Labels: features, newbie
>          Time Spent: 1h
>  Remaining Estimate: 0h
>
> Google recently added support for clustered tables in BigQuery. It would be 
> useful to set clustering columns the same way as for partitioning. It should 
> support multiple fields (4) for clustering.
> For example:
> [BigQueryIO.Write|https://beam.apache.org/documentation/sdks/javadoc/2.6.0/org/apache/beam/sdk/io/gcp/bigquery/BigQueryIO.Write.html]<[T|https://beam.apache.org/documentation/sdks/javadoc/2.6.0/org/apache/beam/sdk/io/gcp/bigquery/BigQueryIO.Write.html]>
>  .withClustering(new Clustering().setField("productId").setType("STRING"))



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to