[
https://issues.apache.org/jira/browse/BEAM-6288?focusedWorklogId=178133&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-178133
]
ASF GitHub Bot logged work on BEAM-6288:
----------------------------------------
Author: ASF GitHub Bot
Created on: 21/Dec/18 19:55
Start Date: 21/Dec/18 19:55
Worklog Time Spent: 10m
Work Description: kennknowles closed pull request #7338: [BEAM-6288] Add
SQL postcommit
URL: https://github.com/apache/beam/pull/7338
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/.test-infra/jenkins/job_PostCommit_SQL.groovy
b/.test-infra/jenkins/job_PostCommit_SQL.groovy
new file mode 100644
index 000000000000..58cf31b8a724
--- /dev/null
+++ b/.test-infra/jenkins/job_PostCommit_SQL.groovy
@@ -0,0 +1,45 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import CommonJobProperties as commonJobProperties
+import PostcommitJobBuilder
+
+// This job runs the Java postcommit tests, including the suite of integration
+// tests.
+PostcommitJobBuilder.postCommitJob('beam_PostCommit_SQL', 'Run SQL PostCommit',
+ 'SQL Post Commit Tests', this) {
+
+ description('Runs PostCommit tests for Beam SQL.')
+
+ // Set common parameters.
+ commonJobProperties.setTopLevelMainJobProperties(delegate, 'master', 240)
+
+ // Publish all test results to Jenkins
+ publishers {
+ archiveJunit('**/build/test-results/**/*.xml')
+ }
+
+ // Gradle goals for this job.
+ steps {
+ gradle {
+ rootBuildScriptDir(commonJobProperties.checkoutDir)
+ tasks(':sqlPostCommit')
+ commonJobProperties.setGradleSwitches(delegate)
+ }
+ }
+}
diff --git a/build.gradle b/build.gradle
index 29ef4a6745b3..c6fd6e7ce074 100644
--- a/build.gradle
+++ b/build.gradle
@@ -204,6 +204,9 @@ task javaPreCommitPortabilityApi() {
task javaPostCommit() {
dependsOn ":beam-runners-google-cloud-dataflow-java:postCommit"
dependsOn ":beam-sdks-java-io-google-cloud-platform:postCommit"
+}
+
+task sqlPostCommit() {
dependsOn ":beam-sdks-java-extensions-sql:postCommit"
dependsOn ":beam-sdks-java-extensions-sql-jdbc:postCommit"
}
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 178133)
Time Spent: 40m (was: 0.5h)
> Separate SQL postcommits from core Java SDK postcommits
> -------------------------------------------------------
>
> Key: BEAM-6288
> URL: https://issues.apache.org/jira/browse/BEAM-6288
> Project: Beam
> Issue Type: Improvement
> Components: build-system
> Reporter: Kenneth Knowles
> Assignee: Kenneth Knowles
> Priority: Minor
> Time Spent: 40m
> Remaining Estimate: 0h
>
> It would add signal clarity to make the postcommits more granular.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
