[
https://issues.apache.org/jira/browse/BEAM-6276?focusedWorklogId=178313&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-178313
]
ASF GitHub Bot logged work on BEAM-6276:
----------------------------------------
Author: ASF GitHub Bot
Created on: 23/Dec/18 08:41
Start Date: 23/Dec/18 08:41
Worklog Time Spent: 10m
Work Description: kanterov commented on issue #7331: [BEAM-6276] Fix
performance regression.
URL: https://github.com/apache/beam/pull/7331#issuecomment-449622403
@reuvenlax I did few hacks, and I was able to achieve almost similar
performance to hand-written code, it 8-10 times faster than now. However, it
requires a few changes:
- `SchemaProvider#schemaFor` needs to be deterministic, could be achieved by
deterministically ordering fields, for instance, by name.
- `FromRowUsingCreator` should be generated by byte-buddy and statically
rely on row schema
- `SetterBasedCreatorFactory` should be generated by byte-buddy, and
implement `SerializationFunction[2-N]` instead of `Object create(Object...
params)` so that `FromRowUsingCreator` can efficiently use it.
I didn't dig deep, but it seems after that, generated code gets inlined into
the equivalent to hand-written code constructions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 178313)
Time Spent: 2h 10m (was: 2h)
> Performance regression caused by extra calls to TypeDescriptor.getRawType
> -------------------------------------------------------------------------
>
> Key: BEAM-6276
> URL: https://issues.apache.org/jira/browse/BEAM-6276
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core
> Reporter: Reuven Lax
> Assignee: Reuven Lax
> Priority: Major
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
