[
https://issues.apache.org/jira/browse/BEAM-6231?focusedWorklogId=179406&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-179406
]
ASF GitHub Bot logged work on BEAM-6231:
----------------------------------------
Author: ASF GitHub Bot
Created on: 28/Dec/18 10:32
Start Date: 28/Dec/18 10:32
Worklog Time Spent: 10m
Work Description: robertwb commented on pull request #7356: [BEAM-6231]
Make Dataflow runner harness work with FixedWindow
URL: https://github.com/apache/beam/pull/7356#discussion_r244297696
##########
File path:
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/graph/CreateExecutableStageNodeFunction.java
##########
@@ -163,7 +167,7 @@ public Node apply(MutableNetwork<Node, Edge> input) {
componentsBuilder.putEnvironments(envId,
Environments.JAVA_SDK_HARNESS_ENVIRONMENT);
}
- // Use default WindowingStrategy as the fake one.
+ // Use default WindowingStrategy as the fake one. But it may be overrided
later if it's a FixedWindow.
// TODO: should get real WindowingStategy from pipeline proto.
Review comment:
So the v1beta3 protos expose neither the windowing strategy nor a reference
that can be used to tie back to the original PCollection? Unfortunate...
In this case, let's add a (possibly memoized) method
`getWindowingStrategyForCoder(Coder<?> windowCoder, componentsBuilder)` rather
than creating and injecting a default and then later possibly overwriting it.
It can have a case for Global and Interval windows, and throw an error
otherwise.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 179406)
Time Spent: 1h 50m (was: 1h 40m)
> Triage test failures introduced by use_executable_stage_bundle_execution
> ------------------------------------------------------------------------
>
> Key: BEAM-6231
> URL: https://issues.apache.org/jira/browse/BEAM-6231
> Project: Beam
> Issue Type: Test
> Components: runner-dataflow
> Reporter: Boyuan Zhang
> Assignee: Boyuan Zhang
> Priority: Major
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
