[
https://issues.apache.org/jira/browse/BEAM-5959?focusedWorklogId=180680&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-180680
]
ASF GitHub Bot logged work on BEAM-5959:
----------------------------------------
Author: ASF GitHub Bot
Created on: 03/Jan/19 13:52
Start Date: 03/Jan/19 13:52
Worklog Time Spent: 10m
Work Description: lgajowy commented on pull request #7266: [BEAM-5959]
Add performance testing for writing many files
URL: https://github.com/apache/beam/pull/7266#discussion_r245005049
##########
File path:
sdks/java/io/file-based-io-tests/src/test/java/org/apache/beam/sdk/io/text/TextIOIT.java
##########
@@ -77,12 +89,40 @@ public static void setup() {
numberOfTextLines = options.getNumberOfRecords();
filenamePrefix = appendTimestampSuffix(options.getFilenamePrefix());
compressionType = Compression.valueOf(options.getCompressionType());
+ numShards = options.getNumShards();
+ bigQueryDataset = options.getBigQueryDataset();
+ bigQueryTable = options.getBigQueryTable();
+ }
+
+ private void publishGcsResults(PipelineResult result) {
Review comment:
The convention in the project (at least the dominant/preferred way) seems to
be the one suggested. We shouldn't change it unless we have a good reason to.
It makes the code easier to read - the reader does not have to scroll through
the implementation details (private methods) to find out what is happening in
the public ones. I know that there are exceptions from this rule in beam code
but I also find those worrying.
I know that at the end of the day it is just a nit, some formatting detail.
Nevertheless, I think we should have at least agree on something in the review
process before merging.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 180680)
Time Spent: 15h 40m (was: 15.5h)
> Add Cloud KMS support to GCS copies
> -----------------------------------
>
> Key: BEAM-5959
> URL: https://issues.apache.org/jira/browse/BEAM-5959
> Project: Beam
> Issue Type: Bug
> Components: io-java-gcp, sdk-py-core
> Reporter: Udi Meiri
> Assignee: Udi Meiri
> Priority: Major
> Time Spent: 15h 40m
> Remaining Estimate: 0h
>
> Beam SDK currently uses the CopyTo GCS API call, which doesn't support
> copying objects that Customer Managed Encryption Keys (CMEK).
> CMEKs are managed in Cloud KMS.
> Items (for Java and Python SDKs):
> - Update clients to versions that support KMS keys.
> - Change copyTo API calls to use rewriteTo (Python - directly, Java -
> possibly convert copyTo API call to use client library)
> - Add unit tests.
> - Add basic tests (DirectRunner and GCS buckets with CMEK).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
