[ 
https://issues.apache.org/jira/browse/BEAM-6333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16733539#comment-16733539
 ] 

Raghu Angadi commented on BEAM-6333:
------------------------------------

Thanks Jan. I agree with everything in the above comment.  2 seconds is 
decumented in JavaDoc for `withLogAppendTime()`

I know it is fairly straight forward option to add ... Since you have a work 
around for now, I will close this for now, though I am not strongly opposed to 
it. It might come up again and we might end up adding it then.

> allow disabling/configuring automatic watermark generation for idle kafka 
> partitions
> ------------------------------------------------------------------------------------
>
>                 Key: BEAM-6333
>                 URL: https://issues.apache.org/jira/browse/BEAM-6333
>             Project: Beam
>          Issue Type: Improvement
>          Components: io-java-kafka
>    Affects Versions: 2.9.0
>            Reporter: Jan Doms
>            Assignee: Raghu Angadi
>            Priority: Major
>              Labels: easyfix, pull-request-available
>   Original Estimate: 0.5h
>          Time Spent: 10m
>  Remaining Estimate: 20m
>
> For pipelines that require the emitted watermarks to be absolutely correct 
> the current behavior using 2 seconds timeout could lead to problems.
> Therefor it should be possible to disable this behavior. While changing the 
> code the hardcoded 2 seconds can also be made configurable. (There's already 
> a TODO about that in the code.)
>  
> A (preliminary) PR making this change is available: 
> https://github.com/apache/beam/pull/7382.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to