[
https://issues.apache.org/jira/browse/BEAM-6240?focusedWorklogId=181876&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-181876
]
ASF GitHub Bot logged work on BEAM-6240:
----------------------------------------
Author: ASF GitHub Bot
Created on: 07/Jan/19 16:06
Start Date: 07/Jan/19 16:06
Worklog Time Spent: 10m
Work Description: kanterov commented on pull request #7289: [BEAM-6240]
Add a library of schema annotations for POJO and JavaBeans
URL: https://github.com/apache/beam/pull/7289#discussion_r245694421
##########
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/utils/ByteBuddyUtils.java
##########
@@ -595,4 +614,163 @@ protected StackManipulation
convertDefault(TypeDescriptor<?> type) {
return readValue;
}
}
+
+ /**
+ * Invokes a constructor registered using SchemaCreate. As constructor
parameters might not be in
+ * the same order as the schema fields, reorders the parameters as necessary
before calling the
Review comment:
I'm going into the territory of composition vs inheritance, but for me, it
was hard to find where re-ordering of fields is happening.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 181876)
> Allow users to annotate POJOs and JavaBeans for richer functionality
> --------------------------------------------------------------------
>
> Key: BEAM-6240
> URL: https://issues.apache.org/jira/browse/BEAM-6240
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-java-core
> Reporter: Reuven Lax
> Assignee: Reuven Lax
> Priority: Major
> Time Spent: 3h
> Remaining Estimate: 0h
>
> Desired annotations:
> * SchemaIgnore - ignore this field
> * FieldName - allow the user to explicitly specify a field name
> * SchemaCreate - register a function to be used to create an object (so
> fields can be final, and no default constructor need be assumed).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
