[
https://issues.apache.org/jira/browse/BEAM-6240?focusedWorklogId=182559&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-182559
]
ASF GitHub Bot logged work on BEAM-6240:
----------------------------------------
Author: ASF GitHub Bot
Created on: 08/Jan/19 17:13
Start Date: 08/Jan/19 17:13
Worklog Time Spent: 10m
Work Description: reuvenlax commented on pull request #7289: [BEAM-6240]
Add a library of schema annotations for POJO and JavaBeans
URL: https://github.com/apache/beam/pull/7289#discussion_r246079132
##########
File path:
sdks/java/core/src/test/java/org/apache/beam/sdk/schemas/utils/POJOUtilsTest.java
##########
@@ -219,11 +231,39 @@ public void testGeneratedByteBufferSetters() {
POJOWithByteArray pojo = new POJOWithByteArray();
List<FieldValueSetter> setters =
POJOUtils.getSetters(
- POJOWithByteArray.class, POJO_WITH_BYTE_ARRAY_SCHEMA, new
JavaFieldTypeSupplier());
+ POJOWithByteArray.class, POJO_WITH_BYTE_ARRAY_SCHEMA,
JavaFieldTypeSupplier.INSTANCE);
setters.get(0).set(pojo, BYTE_ARRAY);
setters.get(1).set(pojo, BYTE_BUFFER.array());
assertArrayEquals("not equal", BYTE_ARRAY, pojo.bytes1);
assertEquals(BYTE_BUFFER, pojo.bytes2);
}
+
+ static class Foo {
Review comment:
I forgot to remove this! done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 182559)
Time Spent: 6h 20m (was: 6h 10m)
> Allow users to annotate POJOs and JavaBeans for richer functionality
> --------------------------------------------------------------------
>
> Key: BEAM-6240
> URL: https://issues.apache.org/jira/browse/BEAM-6240
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-java-core
> Reporter: Reuven Lax
> Assignee: Reuven Lax
> Priority: Major
> Time Spent: 6h 20m
> Remaining Estimate: 0h
>
> Desired annotations:
> * SchemaIgnore - ignore this field
> * FieldName - allow the user to explicitly specify a field name
> * SchemaCreate - register a function to be used to create an object (so
> fields can be final, and no default constructor need be assumed).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
