[
https://issues.apache.org/jira/browse/BEAM-6326?focusedWorklogId=182807&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-182807
]
ASF GitHub Bot logged work on BEAM-6326:
----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Jan/19 02:14
Start Date: 09/Jan/19 02:14
Worklog Time Spent: 10m
Work Description: mxm commented on issue #7432: [BEAM-6326] Relax test
assumption for PAssertTest#testWindowedIsEqualTo
URL: https://github.com/apache/beam/pull/7432#issuecomment-452546561
Actually this does not depend on side inputs, but I'm even seeing this with
`PAssert.that` which does not use side inputs. The following works, note the
comment for the changes:
```
PCollection<Integer> pcollection =
p
.apply(
Create.timestamped(
TimestampedValue.of(43, new Instant(250L)),
TimestampedValue.of(22, new Instant(-250L))))
.apply(Window.into(FixedWindows.of(Duration.millis(500L))))
// CHANGES: Add GroupByKey and re-output the results
.apply(WithKeys.of(0)).apply(GroupByKey.create())
.apply(ParDo.of(new DoFn<KV<Integer, Iterable<Integer>>,
Integer>() {
@ProcessElement
public void processElement(ProcessContext ctxt) {
for (Integer integer : ctxt.element().getValue()) {
ctxt.output(integer);
}
}
}));
PAssert.thatSingleton(pcollection)
.inOnTimePane(new IntervalWindow(new Instant(0L), new Instant(500L)))
.isEqualTo(43);
PAssert.thatSingleton(pcollection)
.inOnTimePane(new IntervalWindow(new Instant(-500L), new
Instant(0L)))
.isEqualTo(22);
```
The existing code on the other hand, always returns `EARLY` panes. The
problem seems to be inside the windowing logic of the Fn Harness.
@robertwb Any opinions on how we should resolve this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 182807)
Time Spent: 40m (was: 0.5h)
> Fix test failures in streaming mode of PortableValidatesRunner
> --------------------------------------------------------------
>
> Key: BEAM-6326
> URL: https://issues.apache.org/jira/browse/BEAM-6326
> Project: Beam
> Issue Type: Test
> Components: runner-flink
> Reporter: Maximilian Michels
> Assignee: Maximilian Michels
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> As of BEAM-6009, the tests are run separately for batch and streaming. This
> has revealed issues with a couple of tests which need to be addressed.
> The Gradle task is: {{validatesPortableRunnerStreaming}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
