[
https://issues.apache.org/jira/browse/BEAM-10308?focusedWorklogId=455049&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-455049
]
ASF GitHub Bot logged work on BEAM-10308:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 06/Jul/20 19:44
Start Date: 06/Jul/20 19:44
Worklog Time Spent: 10m
Work Description: TheNeuralBit commented on a change in pull request
#12067:
URL: https://github.com/apache/beam/pull/12067#discussion_r450442205
##########
File path: sdks/python/apache_beam/transforms/external.py
##########
@@ -286,7 +286,8 @@ def expand(self, pvalueish):
pipeline = (
next(iter(self._inputs.values())).pipeline
if self._inputs else pvalueish.pipeline)
- context = pipeline_context.PipelineContext()
+ context = pipeline_context.PipelineContext(
+ component_id_context=pipeline._component_id_context)
Review comment:
Good point, renamed it to `component_id_map` everywhere
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 455049)
Time Spent: 4h (was: 3h 50m)
> Component id assignement is not consistent across PipelineContext instances
> ---------------------------------------------------------------------------
>
> Key: BEAM-10308
> URL: https://issues.apache.org/jira/browse/BEAM-10308
> Project: Beam
> Issue Type: Bug
> Components: cross-language, sdk-py-core
> Reporter: Brian Hulette
> Assignee: Brian Hulette
> Priority: P1
> Time Spent: 4h
> Remaining Estimate: 0h
>
> The "unique ref" ids used in PipelineContext are generated on the fly, which
> can cause us to get a different id for the same component in different
> contexts.
> This becomes a problem when ExternalTransform is used, because it creates its
> own pipeline context for expansion. So its possible the component ids in the
> expansion request will actually refer to an entirely different component when
> the pipeline is finally assembled for execution.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
