[
https://issues.apache.org/jira/browse/BEAM-10343?focusedWorklogId=456422&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-456422
]
ASF GitHub Bot logged work on BEAM-10343:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Jul/20 05:34
Start Date: 09/Jul/20 05:34
Worklog Time Spent: 10m
Work Description: purbanow commented on a change in pull request #12117:
URL: https://github.com/apache/beam/pull/12117#discussion_r451973374
##########
File path:
sdks/java/io/snowflake/src/main/java/org/apache/beam/sdk/io/snowflake/services/SnowflakeServiceImpl.java
##########
@@ -25,7 +27,9 @@
import java.util.function.Consumer;
import java.util.stream.Collectors;
import javax.sql.DataSource;
+import org.apache.beam.sdk.io.snowflake.data.SnowflakeTableSchema;
import org.apache.beam.sdk.io.snowflake.enums.CloudProvider;
Review comment:
I see your point. I even removed this enum and add following variable to
the Service file:
`private static final String GCS_PREFIX = "gs://";`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 456422)
Time Spent: 2h 50m (was: 2h 40m)
> Add dispositions for SnowflakeIO.write
> --------------------------------------
>
> Key: BEAM-10343
> URL: https://issues.apache.org/jira/browse/BEAM-10343
> Project: Beam
> Issue Type: New Feature
> Components: io-ideas
> Reporter: Pawel Urbanowicz
> Assignee: Pawel Urbanowicz
> Priority: P2
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
