[
https://issues.apache.org/jira/browse/BEAM-10136?focusedWorklogId=457905&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-457905
]
ASF GitHub Bot logged work on BEAM-10136:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 13/Jul/20 08:38
Start Date: 13/Jul/20 08:38
Worklog Time Spent: 10m
Work Description: piotr-szuberski edited a comment on pull request #12145:
URL: https://github.com/apache/beam/pull/12145#issuecomment-657410328
@chamikaramj @TheNeuralBit I've made the requested changes. Also, I found
an utility in JdbcUtil that is able to call proper set method on
PreparedStatement, so I think there is no need to test
BeamRowPreparedStatementSetter separately anymore (there already is a test of
this utility and it would be a copy-paste). I had to make the JdbcUtil class
public instead of package-private because I wanted to have external classes in
separate package.
I'll publish the external builder test after this PR is merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 457905)
Time Spent: 22h 20m (was: 22h 10m)
> Add cross-language wrapper for Java's JdbcIO Write
> --------------------------------------------------
>
> Key: BEAM-10136
> URL: https://issues.apache.org/jira/browse/BEAM-10136
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core
> Affects Versions: Not applicable
> Reporter: Piotr Szuberski
> Assignee: Piotr Szuberski
> Priority: P2
> Labels: portability
> Fix For: Not applicable
>
> Time Spent: 22h 20m
> Remaining Estimate: 0h
>
> Add cross-language wrapper for Java's Jdbc Write
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
