[
https://issues.apache.org/jira/browse/BEAM-10397?focusedWorklogId=459582&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-459582
]
ASF GitHub Bot logged work on BEAM-10397:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 16/Jul/20 00:31
Start Date: 16/Jul/20 00:31
Worklog Time Spent: 10m
Work Description: chamikaramj commented on a change in pull request
#12164:
URL: https://github.com/apache/beam/pull/12164#discussion_r455441379
##########
File path: sdks/python/apache_beam/runners/dataflow/dataflow_runner.py
##########
@@ -864,7 +867,7 @@ def run_GroupByKey(self, transform_node, options):
windowing = transform_node.transform.get_windowing(transform_node.inputs)
step.add_property(
PropertyNames.SERIALIZED_FN,
- self.serialize_windowing_strategy(windowing))
+ self.serialize_windowing_strategy(windowing,
self._default_environment))
Review comment:
Heejong clarified that what we pass here is just the default.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 459582)
Time Spent: 1.5h (was: 1h 20m)
> add missing environment in windowing strategy for Dataflow
> ----------------------------------------------------------
>
> Key: BEAM-10397
> URL: https://issues.apache.org/jira/browse/BEAM-10397
> Project: Beam
> Issue Type: Bug
> Components: cross-language, runner-dataflow
> Reporter: Heejong Lee
> Assignee: Heejong Lee
> Priority: P2
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> add missing environment in windowing strategy for Dataflow
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
