[ https://issues.apache.org/jira/browse/BEAM-6280?focusedWorklogId=183988&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-183988 ]
ASF GitHub Bot logged work on BEAM-6280: ---------------------------------------- Author: ASF GitHub Bot Created on: 10/Jan/19 22:37 Start Date: 10/Jan/19 22:37 Worklog Time Spent: 10m Work Description: rohdesamuel commented on pull request #7433: [BEAM-6280] Refactors Python portability tests to be multi-threaded aware URL: https://github.com/apache/beam/pull/7433#discussion_r246946880 ########## File path: sdks/python/apache_beam/runners/portability/local_job_service.py ########## @@ -102,42 +98,13 @@ def Cancel(self, request, context=None): def GetStateStream(self, request, context=None): job = self._jobs[request.job_id] - state_queue = queue.Queue() - job.add_state_change_callback(state_queue.put) - try: - current_state = state_queue.get() - except queue.Empty: - current_state = job.state - yield beam_job_api_pb2.GetJobStateResponse(state=current_state) - while current_state not in TERMINAL_STATES: - current_state = state_queue.get(block=True) - yield beam_job_api_pb2.GetJobStateResponse(state=current_state) + for state in job.GetStateStream(): + yield state Review comment: Done ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 183988) Time Spent: 3h 10m (was: 3h) > Failure in PortableRunnerTest.test_error_traceback_includes_user_code > --------------------------------------------------------------------- > > Key: BEAM-6280 > URL: https://issues.apache.org/jira/browse/BEAM-6280 > Project: Beam > Issue Type: Bug > Components: sdk-py-core, test-failures > Reporter: Kenneth Knowles > Assignee: Sam Rohde > Priority: Critical > Labels: flaky-test > Time Spent: 3h 10m > Remaining Estimate: 0h > > [https://builds.apache.org/job/beam_PreCommit_Python_Cron/732/] > [https://builds.apache.org/job/beam_PreCommit_Python_Cron/732/testReport/apache_beam.runners.portability.portable_runner_test/PortableRunnerTest/test_error_traceback_includes_user_code/] > [https://scans.gradle.com/s/do3hjulee3gaa/console-log?task=:beam-sdks-python:testPython3] > {code:java} > 'second' not found in 'Traceback (most recent call last):\n File > "/home/jenkins/jenkins-slave/workspace/beam_PreCommit_Python_Cron/src/sdks/python/apache_beam/runners/portability/fn_api_runner_test.py", > line 466, in test_error_traceback_includes_user_code\n p | > beam.Create([0]) | beam.Map(first) # pylint: > disable=expression-not-assigned\n File > "/home/jenkins/jenkins-slave/workspace/beam_PreCommit_Python_Cron/src/sdks/python/apache_beam/pipeline.py", > line 425, in __exit__\n self.run().wait_until_finish()\n File > "/home/jenkins/jenkins-slave/workspace/beam_PreCommit_Python_Cron/src/sdks/python/apache_beam/runners/portability/portable_runner.py", > line 314, in wait_until_finish\n self._job_id, self._state, > self._last_error_message()))\nRuntimeError: Pipeline > job-cdcefe6d-1caa-4487-9e63-e971f67ec68c failed in state FAILED: start > <DataInputOperation receivers=[ConsumerSet[Create/Read/Impulse.out0, > coder=WindowedValueCoder[BytesCoder], len(consumers)=1]]>\n'{code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)