[
https://issues.apache.org/jira/browse/BEAM-10137?focusedWorklogId=462425&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-462425
]
ASF GitHub Bot logged work on BEAM-10137:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 23/Jul/20 07:28
Start Date: 23/Jul/20 07:28
Worklog Time Spent: 10m
Work Description: piotr-szuberski commented on a change in pull request
#12297:
URL: https://github.com/apache/beam/pull/12297#discussion_r459261349
##########
File path:
sdks/java/io/kinesis/src/main/java/org/apache/beam/sdk/io/kinesis/KinesisIO.java
##########
@@ -536,6 +537,13 @@ public Read withMaxCapacityPerShard(Integer maxCapacity) {
return toBuilder().setMaxCapacityPerShard(maxCapacity).build();
}
+ /**
+ * Returns a {@link PTransform} for PCollection of {@link byte[]},
dropping Kinesis metatdata.
+ */
+ public PTransform<PBegin, PCollection<byte[]>> withoutMetadata() {
+ return new TypedWithoutMetadata(this);
+ }
Review comment:
Thanks for pointing it, I followed the KafkaIO convention and didn't
think whether it's a good design or not. The change is trivial, just use
KinesisIO.readWithoutMetadata() and pass Read there instead of creating it in
withoutMetadata(this).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 462425)
Time Spent: 1h 50m (was: 1h 40m)
> Add cross-language wrapper for Java's KinesisIO Read
> ----------------------------------------------------
>
> Key: BEAM-10137
> URL: https://issues.apache.org/jira/browse/BEAM-10137
> Project: Beam
> Issue Type: Sub-task
> Components: cross-language, io-java-kinesis, io-py-aws
> Affects Versions: Not applicable
> Reporter: Piotr Szuberski
> Assignee: Piotr Szuberski
> Priority: P2
> Labels: portability
> Fix For: Not applicable
>
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> Add cross-language wrapper for Java's KinesisIO Read
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
