[
https://issues.apache.org/jira/browse/BEAM-6293?focusedWorklogId=184276&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-184276
]
ASF GitHub Bot logged work on BEAM-6293:
----------------------------------------
Author: ASF GitHub Bot
Created on: 11/Jan/19 17:36
Start Date: 11/Jan/19 17:36
Worklog Time Spent: 10m
Work Description: reuvenlax commented on issue #7334: [BEAM-6293] Infer
schemas from AutoValue classes.
URL: https://github.com/apache/beam/pull/7334#issuecomment-453596513
Makes sense to me. Though I'm not sure if we should relax it for all
JavaBean classes, or just restrict the relaxation to AutoValue objects.
On Fri, Jan 11, 2019 at 7:48 AM Gleb Kanterov <notificati...@github.com>
wrote:
> @reuvenlax <https://github.com/reuvenlax> I was playing around with this
> PR, one thing I've noticed is that ReflectUtils#isGetter seems to be too
> strict. It requires getter method names to start with get and filters out
> this style of AutoValue classes:
>
> @AutoValuepublic abstract class Foo {
> public abstract String bar();
> }
>
> What do you think about relaxing this constraint?
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/beam/pull/7334#issuecomment-453560743>, or mute
> the thread
>
<https://github.com/notifications/unsubscribe-auth/AUGE1ZH8dIt7OiOkUoGRPM9qEe_sej0dks5vCLJVgaJpZM4ZckC9>
> .
>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 184276)
Time Spent: 40m (was: 0.5h)
> Create automatic schema registration for AutoValue classes.
> -----------------------------------------------------------
>
> Key: BEAM-6293
> URL: https://issues.apache.org/jira/browse/BEAM-6293
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-java-core
> Reporter: Reuven Lax
> Assignee: Reuven Lax
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
