[ https://issues.apache.org/jira/browse/BEAM-4606?focusedWorklogId=184285&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-184285 ]
ASF GitHub Bot logged work on BEAM-4606: ---------------------------------------- Author: ASF GitHub Bot Created on: 11/Jan/19 18:07 Start Date: 11/Jan/19 18:07 Worklog Time Spent: 10m Work Description: udim commented on issue #5751: [BEAM-4606] Pin pytz version URL: https://github.com/apache/beam/pull/5751#issuecomment-453605883 The library doesn't follow semver so it's hard to place a reasonable upper bound. Assuming that it's relatively stable, it might be less overhead to remove the upper bound than to keep updating it. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 184285) Time Spent: 1.5h (was: 1h 20m) > Upper bound for pytz dependency > ------------------------------- > > Key: BEAM-4606 > URL: https://issues.apache.org/jira/browse/BEAM-4606 > Project: Beam > Issue Type: Improvement > Components: sdk-py-core > Reporter: Ahmet Altay > Assignee: Udi Meiri > Priority: Major > Fix For: Not applicable > > Time Spent: 1.5h > Remaining Estimate: 0h > > Do we need an upper bound for the pytz dependency? > ([https://github.com/apache/beam/blob/release-2.5.0/sdks/python/setup.py#L108)] > We typically have upper bounds, in order to avoid future breakages due to a > possibility of breaking/backward incompatible change of that depepdency. > Good practice is to upper bound either at known version, or next major > version. Do we need an exception for pytz because it does not seem to be > following semantic versioning? > cc: [~yifanzou] Is this something dependency notifier can warn on? Dependency > without upper version bounds. -- This message was sent by Atlassian JIRA (v7.6.3#76005)