[ https://issues.apache.org/jira/browse/BEAM-6231?focusedWorklogId=184312&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-184312 ]
ASF GitHub Bot logged work on BEAM-6231: ---------------------------------------- Author: ASF GitHub Bot Created on: 11/Jan/19 19:38 Start Date: 11/Jan/19 19:38 Worklog Time Spent: 10m Work Description: boyuanzz commented on pull request #7356: [BEAM-6231] Make Dataflow runner harness work with FixedWindow URL: https://github.com/apache/beam/pull/7356#discussion_r247232400 ########## File path: runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/graph/CreateExecutableStageNodeFunction.java ########## @@ -195,38 +200,8 @@ public Node apply(MutableNetwork<Node, Edge> input) { Iterables.filter(input.nodes(), InstructionOutputNode.class)) { InstructionOutput instructionOutput = node.getInstructionOutput(); - // If this is the input PCollection or the output PCollection for an ExecutableStage, it's - // necessary to check whether the window coder is not a GlobalWindow coder. - if (isExecutableStageInputPCollection(input, node) - || isExecutableStageOutputPCollection(input, node)) { - Coder<?> javaCoder = - CloudObjects.coderFromCloudObject(CloudObject.fromSpec(instructionOutput.getCodec())); - // For now, Dataflow runner harness only deal with FixedWindow. - if (FullWindowedValueCoder.class.isInstance(javaCoder)) { - FullWindowedValueCoder<?> windowedValueCoder = (FullWindowedValueCoder<?>) javaCoder; - Coder<?> windowCoder = windowedValueCoder.getWindowCoder(); - if (IntervalWindowCoder.class.isInstance(windowCoder)) { - fakeWindowingStrategyId = "generatedFixedWindowingStrategy" + idGenerator.getId(); - try { - // Since the coder is the only needed from a WindowingStrategy, the size field of one - // FixedWindows is meaningless here. - RunnerApi.MessageWithComponents windowingStrategyProto = - WindowingStrategyTranslation.toMessageProto( - WindowingStrategy.of(FixedWindows.of(Duration.standardSeconds(1))), - sdkComponents); - componentsBuilder.putWindowingStrategies( - fakeWindowingStrategyId, windowingStrategyProto.getWindowingStrategy()); - componentsBuilder.putAllCoders(windowingStrategyProto.getComponents().getCodersMap()); - componentsBuilder.putAllEnvironments( - windowingStrategyProto.getComponents().getEnvironmentsMap()); - } catch (IOException exc) { - throw new RuntimeException("Could not convert FixedWindow stratey to proto", exc); - } - } - } - } - String coderId = "generatedCoder" + idGenerator.getId(); + String windowingStrategyId = fakeGlobalWindowingStrategyId; Review comment: I don't think we should have an exception clause if this is not a java coder. In my latest changes, I set it to use GlobalWindow if it's not a java coder. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 184312) Time Spent: 5.5h (was: 5h 20m) > Triage test failures introduced by use_executable_stage_bundle_execution > ------------------------------------------------------------------------ > > Key: BEAM-6231 > URL: https://issues.apache.org/jira/browse/BEAM-6231 > Project: Beam > Issue Type: Test > Components: runner-dataflow > Reporter: Boyuan Zhang > Assignee: Boyuan Zhang > Priority: Major > Time Spent: 5.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.3#76005)