[
https://issues.apache.org/jira/browse/BEAM-6184?focusedWorklogId=184396&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-184396
]
ASF GitHub Bot logged work on BEAM-6184:
----------------------------------------
Author: ASF GitHub Bot
Created on: 11/Jan/19 23:06
Start Date: 11/Jan/19 23:06
Worklog Time Spent: 10m
Work Description: kennknowles commented on pull request #7454:
[BEAM-6184] Enforce javadoc check on non-trivial public methods
URL: https://github.com/apache/beam/pull/7454#discussion_r247280005
##########
File path:
runners/flink/src/main/java/org/apache/beam/runners/flink/translation/functions/FlinkExecutableStageFunction.java
##########
@@ -331,10 +331,8 @@ private void fireTimer(
public void close() throws Exception {
// close may be called multiple times when an exception is thrown
if (stageContext != null) {
- try (@SuppressWarnings("unused")
Review comment:
Sounds good to me. If we care about unused variables, we can turn it on
again. Removed the not-needed annotation is an improvement.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 184396)
Time Spent: 2h 50m (was: 2h 40m)
> PortableRunner dependency missed in wordcount example maven artifact
> --------------------------------------------------------------------
>
> Key: BEAM-6184
> URL: https://issues.apache.org/jira/browse/BEAM-6184
> Project: Beam
> Issue Type: Improvement
> Components: build-system
> Reporter: Ruoyun Huang
> Assignee: Ruoyun Huang
> Priority: Minor
> Fix For: Not applicable
>
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
>
>
> more context:
> https://lists.apache.org/thread.html/8dd60395424425f7502d62888c49014430d1d3b06c026606f3db28ab@%3Cuser.beam.apache.org%3E
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
