[
https://issues.apache.org/jira/browse/BEAM-3608?focusedWorklogId=184740&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-184740
]
ASF GitHub Bot logged work on BEAM-3608:
----------------------------------------
Author: ASF GitHub Bot
Created on: 14/Jan/19 10:18
Start Date: 14/Jan/19 10:18
Worklog Time Spent: 10m
Work Description: iemejia commented on issue #7494: [BEAM-3608] Port
shaded Guava to vendored Guava
URL: https://github.com/apache/beam/pull/7494#issuecomment-453956183
What I mean in (2) is that probably we should make exclude the default and
make the packages who need still to shadow deps opt-in because they are less.
WDYT @kennknowles @swegner ? (or something like that).
```Java
applyJavaNature(shadowClosure: {
dependencies {
exclude { true }
}
})
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 184740)
Time Spent: 9h 20m (was: 9h 10m)
> Vendor Guava
> ------------
>
> Key: BEAM-3608
> URL: https://issues.apache.org/jira/browse/BEAM-3608
> Project: Beam
> Issue Type: Sub-task
> Components: runner-core, sdk-java-core
> Reporter: Kenneth Knowles
> Assignee: Kenneth Knowles
> Priority: Major
> Time Spent: 9h 20m
> Remaining Estimate: 0h
>
> Instead of shading as part of our build, we can shade before build so that it
> is apparent when reading code, and in IDEs, that a particular class resides
> in a hidden namespace.
> {{import com.google.common.reflect.TypeToken}}
> becomes something like
> {{import org.apache.beam.private.guava21.com.google.common.reflect.TypeToken}}
> So we can very trivially ban `org.apache.beam.private` from public APIs
> unless they are annotated {{@Internal}}, and it makes sharing between our own
> modules never get broken by shading again.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
