[
https://issues.apache.org/jira/browse/BEAM-10135?focusedWorklogId=465601&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-465601
]
ASF GitHub Bot logged work on BEAM-10135:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 03/Aug/20 09:29
Start Date: 03/Aug/20 09:29
Worklog Time Spent: 10m
Work Description: piotr-szuberski commented on pull request #12423:
URL: https://github.com/apache/beam/pull/12423#issuecomment-667916022
> "During writing kinesis for cross-language it was suggested to emplace all
classes connected to cross-language in one file"
>
> I think Java generally recommends keeping classes in separate files,
doesn't it ? I think either way should be fine as long as x-lang framework is
concerned.
@chamikaramj In general yes, but most of beam connectors have huge files
with nested classes instead of splitting them to separate packages and small
files. In the case of external transforms it's a bit more elegant because
ExternalTransformRegistrar has to override function knownTransforms() which
assumes there can be more than one transform under it. The builders actually
should also be in separate files from the registrar.
But I agree that it's not that necessary to put everything into one file, so
if you prefer it to be like it is now then I'll close this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 465601)
Time Spent: 14h (was: 13h 50m)
> Add cross-language wrapper for Java's JdbcIO Read
> -------------------------------------------------
>
> Key: BEAM-10135
> URL: https://issues.apache.org/jira/browse/BEAM-10135
> Project: Beam
> Issue Type: Sub-task
> Components: cross-language, io-java-jdbc
> Affects Versions: Not applicable
> Reporter: Piotr Szuberski
> Assignee: Piotr Szuberski
> Priority: P2
> Labels: portability
> Fix For: Not applicable
>
> Time Spent: 14h
> Remaining Estimate: 0h
>
> Add cross-language wrapper for Java's Jdbc Read
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
