[
https://issues.apache.org/jira/browse/BEAM-10557?focusedWorklogId=467320&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-467320
]
ASF GitHub Bot logged work on BEAM-10557:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 06/Aug/20 14:38
Start Date: 06/Aug/20 14:38
Worklog Time Spent: 10m
Work Description: sclukas77 commented on a change in pull request #12341:
URL: https://github.com/apache/beam/pull/12341#discussion_r466461253
##########
File path:
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/meta/provider/datastore/DataStoreV1TableProvider.java
##########
@@ -39,15 +43,14 @@
* }</pre>
*/
@AutoService(TableProvider.class)
-public class DataStoreV1TableProvider extends InMemoryMetaTableProvider {
-
+public class DataStoreV1TableProvider extends SchemaIOTableProviderWrapper {
@Override
- public String getTableType() {
- return "datastoreV1";
+ public SchemaIOProvider getSchemaIOProvider() {
+ return new DataStoreV1SchemaIOProvider();
}
@Override
- public BeamSqlTable buildBeamSqlTable(Table table) {
- return new DataStoreV1Table(table);
+ public String getTableType() {
+ return "datastoreV1";
Review comment:
Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 467320)
Time Spent: 1h (was: 50m)
> Move DataStoreV1 Logic to Core Beam
> -----------------------------------
>
> Key: BEAM-10557
> URL: https://issues.apache.org/jira/browse/BEAM-10557
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-core
> Reporter: Scott Lukas
> Assignee: Scott Lukas
> Priority: P2
> Labels: schema-io
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Implement SchemaIO and SchemaCapableIOProvider for DataStoreV1.
> Additional details:
> [https://docs.google.com/document/d/1ic3P8EVGHIydHQ-VMDKbN9kEdwm7sBXMo80VrhwksvI/edit?ts=5ef631ef#]
> [~bhulette]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
