[ https://issues.apache.org/jira/browse/BEAM-5446?focusedWorklogId=185017&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-185017 ]
ASF GitHub Bot logged work on BEAM-5446: ---------------------------------------- Author: ASF GitHub Bot Created on: 14/Jan/19 23:26 Start Date: 14/Jan/19 23:26 Worklog Time Spent: 10m Work Description: kennknowles commented on pull request #6467: [BEAM-5446] SplittableDoFn: Remove "internal" methods for public API surface URL: https://github.com/apache/beam/pull/6467#discussion_r247705762 ########## File path: sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/reflect/DoFnSignatures.java ########## @@ -610,11 +591,9 @@ private static void verifySplittableMethods(DoFnSignature signature, ErrorReport errors.forMethod(DoFn.GetInitialRestriction.class, getInitialRestriction.targetMethod()); TypeDescriptor<?> restrictionT = getInitialRestriction.restrictionT(); processElementErrors.checkArgument( - processElement.trackerT().equals(trackerT), - "Has tracker type %s, but the DoFn's tracker type was inferred as %s from %s", - formatType(processElement.trackerT()), - trackerT, - originOfTrackerT); + processElement.trackerT().getRawType().equals(RestrictionTracker.class), Review comment: This seems like it should be a subtype check. What was wrong with the prior code? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 185017) Time Spent: 1h 50m (was: 1h 40m) > SplittableDoFn: Remove runner time execution information from public API > surface > -------------------------------------------------------------------------------- > > Key: BEAM-5446 > URL: https://issues.apache.org/jira/browse/BEAM-5446 > Project: Beam > Issue Type: Improvement > Components: sdk-java-core > Reporter: Luke Cwik > Assignee: Luke Cwik > Priority: Minor > Fix For: 2.9.0 > > Time Spent: 1h 50m > Remaining Estimate: 0h > > Move the setting of "claim observers" within RestrictionTracker to another > location to clean up the RestrictionTracker interface. -- This message was sent by Atlassian JIRA (v7.6.3#76005)