[ 
https://issues.apache.org/jira/browse/BEAM-6404?focusedWorklogId=185097&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-185097
 ]

ASF GitHub Bot logged work on BEAM-6404:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 15/Jan/19 03:31
            Start Date: 15/Jan/19 03:31
    Worklog Time Spent: 10m 
      Work Description: udim commented on pull request #7456: [BEAM-6404] Fix 
issue with side inputs and flatten encoding.
URL: https://github.com/apache/beam/pull/7456#discussion_r247754156
 
 

 ##########
 File path: 
sdks/python/apache_beam/runners/portability/fn_api_runner_transforms.py
 ##########
 @@ -591,7 +591,6 @@ def sink_flattens(stages, pipeline_context):
         if pcollections[pcoll_in].coder_id != output_coder_id:
           # Flatten inputs must all be written with the same coder as is
 
 Review comment:
   I think this comment would be better like this:
   `Flatten requires that all its inputs use the same coder as its output. Add 
stages to transcode Flatten inputs that do not use the same coder.`
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 185097)
    Time Spent: 0.5h  (was: 20m)

> FnAPI translation error
> -----------------------
>
>                 Key: BEAM-6404
>                 URL: https://issues.apache.org/jira/browse/BEAM-6404
>             Project: Beam
>          Issue Type: New Feature
>          Components: sdk-py-core
>            Reporter: Robert Bradshaw
>            Assignee: Robert Bradshaw
>            Priority: Major
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
>  {code:java}
> def run(argv=None):
>   parser = argparse.ArgumentParser()
>   _, pipeline_args = parser.parse_known_args(argv)
>   options = pipeline_options.PipelineOptions(pipeline_args)
>   numbers = [1, 2]
>   with beam.Pipeline(options=options) as p:
>     sum_1 = (p
>              | 'ReadNumber1' >> transforms.Create(numbers)
>              | 'CalculateSum1' >> beam.CombineGlobally(fn_sum))
>     sum_2 = (p
>              | 'ReadNumber2' >> transforms.Create(numbers)
>              | beam.ParDo(_copy_number, pvalue.AsSingleton(sum_1))
>              | 'CalculateSum2' >> beam.CombineGlobally(fn_sum))
>     _ = ((sum_1, sum_2)
>          | beam.Flatten()
>          | 'CalculateSum3' >> beam.CombineGlobally(fn_sum)
>          | beam.io.WriteToText('out.txt'))
> run()
> {code}
>  
> fails with 
> KeyError: u'ref_Coder_FastPrimitivesCoder_4_windowed'



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to