[
https://issues.apache.org/jira/browse/BEAM-10612?focusedWorklogId=470752&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-470752
]
ASF GitHub Bot logged work on BEAM-10612:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 14/Aug/20 16:36
Start Date: 14/Aug/20 16:36
Worklog Time Spent: 10m
Work Description: mxm commented on a change in pull request #12564:
URL: https://github.com/apache/beam/pull/12564#discussion_r470732067
##########
File path:
runners/flink/src/main/java/org/apache/beam/runners/flink/translation/wrappers/streaming/DoFnOperator.java
##########
@@ -699,7 +699,7 @@ public final void processWatermark1(Watermark mark) throws
Exception {
long inputWatermarkHold =
applyInputWatermarkHold(getEffectiveInputWatermark());
if (keyCoder != null) {
- timeServiceManager.advanceWatermark(new Watermark(inputWatermarkHold));
+ getTimeServiceManagerCompat().advanceWatermark(new
Watermark(inputWatermarkHold));
Review comment:
Maybe add a field for this instead of calling the getter every time?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 470752)
Time Spent: 1h 10m (was: 1h)
> Add support for Flink 1.11.0
> ----------------------------
>
> Key: BEAM-10612
> URL: https://issues.apache.org/jira/browse/BEAM-10612
> Project: Beam
> Issue Type: Wish
> Components: runner-flink
> Reporter: Kyle Weaver
> Assignee: Neville Li
> Priority: P2
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> Flink 1.11.0 was released on July 6, 2020:
> [https://flink.apache.org/news/2020/07/06/release-1.11.0.html]
> We should add a Flink 1.11 module to Beam.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
