[
https://issues.apache.org/jira/browse/BEAM-6339?focusedWorklogId=185581&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-185581
]
ASF GitHub Bot logged work on BEAM-6339:
----------------------------------------
Author: ASF GitHub Bot
Created on: 16/Jan/19 04:59
Start Date: 16/Jan/19 04:59
Worklog Time Spent: 10m
Work Description: HuangLED commented on issue #7390: [BEAM-6339] Add
paddedcell fix to spotlessJava rules.
URL: https://github.com/apache/beam/pull/7390#issuecomment-454652391
> What was the actual issue? It looks like paddedCell has bugs, itself. It
seems that we are OK at current head.
oops... The story was: I was testing whether our tools were able to catch
code style violations as they claim. I thus intentionally created different
violations, for verification purpose.
The issue happened with those intentional changes. That is, instead of
reporting those actual, although intentional, violations, the build system was
failing. I didn't keep my changes, thus will need to check which exactly
violation (something related to class level javadoc).
Back then, I thought it would be an improvement, which is even though minor,
but good to have, thus requested this PR since I was already on it.
Is this causing issue? Do you prefer us to revert this PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 185581)
Time Spent: 50m (was: 40m)
> In certain cases, spotlessJava fails to work
> --------------------------------------------
>
> Key: BEAM-6339
> URL: https://issues.apache.org/jira/browse/BEAM-6339
> Project: Beam
> Issue Type: Improvement
> Components: build-system
> Reporter: Ruoyun Huang
> Assignee: Ruoyun Huang
> Priority: Trivial
> Fix For: Not applicable
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Encounter following error when certain criteria exists in new code:
>
> > Task :beam-runners-google-cloud-dataflow-java:spotlessJava FAILED
>
> FAILURE: Build failed with an exception.
> * What went wrong:
> Execution failed for task
> ':beam-runners-google-cloud-dataflow-java:spotlessJava'.
> > You have a misbehaving rule which can't make up its mind.
> This means that spotlessCheck will fail even after spotlessApply has run.
>
> This is a bug in a formatting rule, not Spotless itself, but Spotless can
> work around this bug and generate helpful bug reports for the broken rule
> if you add 'paddedCell()' to your build.gradle as such:
>
> spotless {
> format 'someFormat', {
> ...
> paddedCell()
> }
> }
>
> The next time you run spotlessCheck, it will put helpful bug reports into
> 'runners/google-cloud-dataflow-java/build/spotless-diagnose-java', and
> spotlessApply
> and spotlessCheck will be self-consistent from here on out.
>
> For details see
> [https://github.com/diffplug/spotless/blob/master/PADDEDCELL.md]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
