[ 
https://issues.apache.org/jira/browse/BEAM-10779?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Yifan Mai updated BEAM-10779:
-----------------------------
    Description: 
Currently, {{PTransformOverride}} only supports overriding {{PTransform}}s that 
have a [single  
input|https://github.com/apache/beam/blob/cfa448d121297398312d09c531258a72b413488b/sdks/python/apache_beam/pipeline.py#L311-L317].
 It would be useful to support multiple main inputs and side inputs as well.

Proposal:
* Introduce a new method {{PTransformOverride.get_replacement_inputs(self, 
applied_ptransform)}} that can be overridden by end users. This method will be 
called to get the inputs for the replacement PTransform.
* The default implementation will return a tuple of all the main inputs in 
order, concatenated with the all the side inputs {{PValue}}s in order.

  was:
Currently, `PTransformOverride` only supports overriding `PTransform`s that 
have a [single  
input](https://github.com/apache/beam/blob/cfa448d121297398312d09c531258a72b413488b/sdks/python/apache_beam/pipeline.py#L311-L317).
 It would be useful to support multiple main inputs and side inputs as well.

Proposal:
* Introduce a new method `PTransformOverride.get_replacement_inputs(self, 
applied_ptransform)` that can be overridden by end users. This method will be 
called to get the inputs for the replacement PTransform.
* The default implementation will return a tuple of all the main inputs in 
order, concatenated with the all the side inputs `PValue`s in order.


> Support multiple main inputs and side inputs for PTransformOverride
> -------------------------------------------------------------------
>
>                 Key: BEAM-10779
>                 URL: https://issues.apache.org/jira/browse/BEAM-10779
>             Project: Beam
>          Issue Type: New Feature
>          Components: sdk-py-core
>            Reporter: Yifan Mai
>            Assignee: Yifan Mai
>            Priority: P2
>
> Currently, {{PTransformOverride}} only supports overriding {{PTransform}}s 
> that have a [single  
> input|https://github.com/apache/beam/blob/cfa448d121297398312d09c531258a72b413488b/sdks/python/apache_beam/pipeline.py#L311-L317].
>  It would be useful to support multiple main inputs and side inputs as well.
> Proposal:
> * Introduce a new method {{PTransformOverride.get_replacement_inputs(self, 
> applied_ptransform)}} that can be overridden by end users. This method will 
> be called to get the inputs for the replacement PTransform.
> * The default implementation will return a tuple of all the main inputs in 
> order, concatenated with the all the side inputs {{PValue}}s in order.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to