[ 
https://issues.apache.org/jira/browse/BEAM-6339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16744360#comment-16744360
 ] 

Ruoyun Huang commented on BEAM-6339:
------------------------------------

Didn't keep my change. :(       

 

I remember all I did was just removing existing comment (in a few randomly 
picked files), rather than anything too creative.  Just now I tried again but 
can no longer reproduce.  I suspect it only gets triggered when the violation 
is in certain files.  

 

Will keep an eye on this and bring it to broader attention if see the build 
failure next time. 

 

 

> In certain cases, spotlessJava fails to work
> --------------------------------------------
>
>                 Key: BEAM-6339
>                 URL: https://issues.apache.org/jira/browse/BEAM-6339
>             Project: Beam
>          Issue Type: Improvement
>          Components: build-system
>            Reporter: Ruoyun Huang
>            Assignee: Ruoyun Huang
>            Priority: Trivial
>             Fix For: Not applicable
>
>          Time Spent: 1h
>  Remaining Estimate: 0h
>
> Encounter following error when certain criteria exists in new code: 
>  
> > Task :beam-runners-google-cloud-dataflow-java:spotlessJava FAILED
>  
> FAILURE: Build failed with an exception.
>  * What went wrong:
> Execution failed for task 
> ':beam-runners-google-cloud-dataflow-java:spotlessJava'.
> > You have a misbehaving rule which can't make up its mind.
>  This means that spotlessCheck will fail even after spotlessApply has run.
>  
>  This is a bug in a formatting rule, not Spotless itself, but Spotless can
>  work around this bug and generate helpful bug reports for the broken rule
>  if you add 'paddedCell()' to your build.gradle as such: 
>  
>  spotless {
>  format 'someFormat', {
>  ...
>  paddedCell()
>  }
>  }
>  
>  The next time you run spotlessCheck, it will put helpful bug reports into
>  'runners/google-cloud-dataflow-java/build/spotless-diagnose-java', and 
> spotlessApply
>  and spotlessCheck will be self-consistent from here on out.
>  
>  For details see 
> [https://github.com/diffplug/spotless/blob/master/PADDEDCELL.md]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to