[
https://issues.apache.org/jira/browse/BEAM-5933?focusedWorklogId=185973&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-185973
]
ASF GitHub Bot logged work on BEAM-5933:
----------------------------------------
Author: ASF GitHub Bot
Created on: 16/Jan/19 20:22
Start Date: 16/Jan/19 20:22
Worklog Time Spent: 10m
Work Description: kennknowles commented on issue #6909: BEAM-5933: avoid
memory allocation in hashCode call
URL: https://github.com/apache/beam/pull/6909#issuecomment-454926181
Out of curiosity, did you measure the allocation and its cost?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 185973)
Time Spent: 40m (was: 0.5h)
> PCollectionViews$SimplePCollectionView.hashCode allocates memory
> ----------------------------------------------------------------
>
> Key: BEAM-5933
> URL: https://issues.apache.org/jira/browse/BEAM-5933
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-core
> Affects Versions: 2.8.0
> Reporter: Vojtech Janota
> Assignee: Vojtech Janota
> Priority: Trivial
> Fix For: 2.9.0
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> I'm currently profiling memory consumption of our Beam pipeline and have
> noticed that
>
> org.apache.beam.sdk.values.PCollectionViews$SimplePCollectionView.hashCode()
> makes noticeable heap allocations. The implementation is:
> return Objects.hash(tag);
> That itself translates to:
> return Arrays.hashCode(values);
> Which performs implicit array creation in order to call:
> public static int Arrays.hashCode(Object a[]);
> Instead of the helper call, doing simple:
> tag.hashCode();
> Seems more appropriate.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
