[ https://issues.apache.org/jira/browse/BEAM-6447?focusedWorklogId=186057&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-186057 ]
ASF GitHub Bot logged work on BEAM-6447: ---------------------------------------- Author: ASF GitHub Bot Created on: 16/Jan/19 23:38 Start Date: 16/Jan/19 23:38 Worklog Time Spent: 10m Work Description: reuvenlax commented on issue #7531: [BEAM-6447] Turn off spotless paddedCell URL: https://github.com/apache/beam/pull/7531#issuecomment-454985815 Run Java_Examples_Dataflow PreCommit ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 186057) Time Spent: 3h (was: 2h 50m) > Spotless paddedCell appears to cause unpredictable behavior > ----------------------------------------------------------- > > Key: BEAM-6447 > URL: https://issues.apache.org/jira/browse/BEAM-6447 > Project: Beam > Issue Type: Bug > Components: build-system > Reporter: Kenneth Knowles > Assignee: Kenneth Knowles > Priority: Major > Time Spent: 3h > Remaining Estimate: 0h > > In https://github.com/apache/beam/pull/7505 spotlessCheck passed even though > spotlessApply was not a no-op. > In https://github.com/apache/beam/pull/7523 and > https://github.com/apache/beam/pull/7527 spotlessApply was run and the result > _also_ passed spotlessCheck. > Confirmed that spotlessCheck fails on > https://github.com/apache/beam/pull/7505 if paddedCell is turned off. The use > of paddedCell is to workaround bugs in the underlying formatter (in our case > google-java-format). Currently, there is no known bug affecting us, so we > should not be using paddedCell. -- This message was sent by Atlassian JIRA (v7.6.3#76005)