[ https://issues.apache.org/jira/browse/BEAM-6407?focusedWorklogId=186450&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-186450 ]
ASF GitHub Bot logged work on BEAM-6407: ---------------------------------------- Author: ASF GitHub Bot Created on: 17/Jan/19 17:35 Start Date: 17/Jan/19 17:35 Worklog Time Spent: 10m Work Description: kennknowles commented on pull request #7550: [BEAM-6407] Cherry pick #7537, fixes FileIO.writeDynamic() in the DirectRunner URL: https://github.com/apache/beam/pull/7550 ------------------------ Follow this checklist to help us incorporate your contribution quickly and easily: - [x] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue. - [x] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). It will help us expedite review of your Pull Request if you tag someone (e.g. `@username`) to look at it. Post-Commit Tests Status (on master branch) ------------------------------------------------------------------------------------------------ Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark --- | --- | --- | --- | --- | --- | --- | --- Go | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | --- | --- | --- | --- | --- Java | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/) Python | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Python_Verify/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Python_Verify/lastCompletedBuild/) | --- | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/) </br> [![Build Status](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Python_VR_Flink/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Python_VR_Flink/lastCompletedBuild/) | --- | --- | --- ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 186450) Time Spent: 2h 20m (was: 2h 10m) > regression: FileIO.writeDynamic() with side inputs fails in DirectRunner > ------------------------------------------------------------------------ > > Key: BEAM-6407 > URL: https://issues.apache.org/jira/browse/BEAM-6407 > Project: Beam > Issue Type: Bug > Components: runner-direct > Affects Versions: 2.9.0 > Reporter: Niel Markwick > Assignee: Niel Markwick > Priority: Blocker > Labels: regression > Fix For: 2.10.0 > > Attachments: beam-filewriter-demo.tgz > > Time Spent: 2h 20m > Remaining Estimate: 0h > > When FileIO.writeDynamic is used with automatic sharding and a Contextful.Fn > that uses side inputs for the file naming, DirectRunner (and TestPipeline) > fail with: > {{java.lang.IllegalStateException: All PCollectionViews that are consumed > must be written by some WriteView PTransform: Missing [<unnamed> > [RunnerPCollectionView]]}} > > Example code: > {code:java} > PCollectionView<String> outputFileName = > pipeline.apply( > "outputDir", > Create.of("/tmp/testout")).apply(View.asSingleton()); > Contextful.Fn<String, FileIO.Write.FileNaming> manifestNaming = > (element, c) -> > (window, pane, numShards, shardIndex, compression) -> > c.sideInput(outputFileName)+shardIndex; > pipeline.apply(FileIO.<String, String>writeDynamic() > .by(SerializableFunctions.constant("")) > .withDestinationCoder(StringUtf8Coder.of()) > .via(TextIO.sink()) > .withTempDirectory("/tmp") > .withNaming(Contextful.of( > manifestNaming, > Requirements.requiresSideInputs(outputFileName)))); > {code} > > This does not occur in Dataflow-runner > It does not occur if the ContextFul.Fn is not given side inputs. > It does not occur if withNumShards(1) is set. > It did not occur in 2.8.0, and does in 2.9.0 and 2.10.0-SNAPSHOT (as of today) > > The cause appears to be due to the DirectRunner using TransformOverrides > re-writing FileIO sinks to use runner-determined-sharding > ( see [DirectRunner.java line > 226|https://github.com/apache/beam/blob/master/runners/direct-java/src/main/java/org/apache/beam/runners/direct/DirectRunner.java#L226] > ) > but I do not know why this started occuring in 2.9.0... -- This message was sent by Atlassian JIRA (v7.6.3#76005)