[
https://issues.apache.org/jira/browse/BEAM-10781?focusedWorklogId=476406&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-476406
]
ASF GitHub Bot logged work on BEAM-10781:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 31/Aug/20 07:49
Start Date: 31/Aug/20 07:49
Worklog Time Spent: 10m
Work Description: codecov[bot] edited a comment on pull request #12656:
URL: https://github.com/apache/beam/pull/12656#issuecomment-683610379
# [Codecov](https://codecov.io/gh/apache/beam/pull/12656?src=pr&el=h1) Report
> Merging
[#12656](https://codecov.io/gh/apache/beam/pull/12656?src=pr&el=desc) into
[master](https://codecov.io/gh/apache/beam/commit/cfa448d121297398312d09c531258a72b413488b?el=desc)
will **decrease** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12656?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12656 +/- ##
==========================================
- Coverage 34.47% 34.47% -0.01%
==========================================
Files 684 684
Lines 81483 81492 +9
Branches 9180 9180
==========================================
+ Hits 28090 28093 +3
- Misses 52965 52978 +13
+ Partials 428 421 -7
```
| [Impacted
Files](https://codecov.io/gh/apache/beam/pull/12656?src=pr&el=tree) | Coverage
Δ | |
|---|---|---|
|
[runners/dataflow/ptransform\_overrides.py](https://codecov.io/gh/apache/beam/pull/12656/diff?src=pr&el=tree#diff-cnVubmVycy9kYXRhZmxvdy9wdHJhbnNmb3JtX292ZXJyaWRlcy5weQ==)
| `17.85% <0.00%> (-0.26%)` | :arrow_down: |
|
[runners/direct/sdf\_direct\_runner.py](https://codecov.io/gh/apache/beam/pull/12656/diff?src=pr&el=tree#diff-cnVubmVycy9kaXJlY3Qvc2RmX2RpcmVjdF9ydW5uZXIucHk=)
| `33.06% <0.00%> (-0.14%)` | :arrow_down: |
|
[runners/direct/direct\_runner.py](https://codecov.io/gh/apache/beam/pull/12656/diff?src=pr&el=tree#diff-cnVubmVycy9kaXJlY3QvZGlyZWN0X3J1bm5lci5weQ==)
| `32.77% <0.00%> (-0.11%)` | :arrow_down: |
|
[pipeline\_test.py](https://codecov.io/gh/apache/beam/pull/12656/diff?src=pr&el=tree#diff-cGlwZWxpbmVfdGVzdC5weQ==)
| `24.74% <0.00%> (-0.06%)` | :arrow_down: |
|
[io/mongodbio\_test.py](https://codecov.io/gh/apache/beam/pull/12656/diff?src=pr&el=tree#diff-aW8vbW9uZ29kYmlvX3Rlc3QucHk=)
| `34.95% <0.00%> (ø)` | |
|
[io/gcp/experimental/spannerio.py](https://codecov.io/gh/apache/beam/pull/12656/diff?src=pr&el=tree#diff-aW8vZ2NwL2V4cGVyaW1lbnRhbC9zcGFubmVyaW8ucHk=)
| `34.49% <0.00%> (ø)` | |
|
[typehints/typed\_pipeline\_test.py](https://codecov.io/gh/apache/beam/pull/12656/diff?src=pr&el=tree#diff-dHlwZWhpbnRzL3R5cGVkX3BpcGVsaW5lX3Rlc3QucHk=)
| `21.98% <0.00%> (ø)` | |
|
[runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/12656/diff?src=pr&el=tree#diff-cnVubmVycy93b3JrZXIvYnVuZGxlX3Byb2Nlc3Nvci5weQ==)
| `28.45% <0.00%> (ø)` | |
|
[runners/dataflow/dataflow\_runner\_test.py](https://codecov.io/gh/apache/beam/pull/12656/diff?src=pr&el=tree#diff-cnVubmVycy9kYXRhZmxvdy9kYXRhZmxvd19ydW5uZXJfdGVzdC5weQ==)
| `25.49% <0.00%> (ø)` | |
|
[pipeline.py](https://codecov.io/gh/apache/beam/pull/12656/diff?src=pr&el=tree#diff-cGlwZWxpbmUucHk=)
| `22.68% <0.00%> (+0.36%)` | :arrow_up: |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/beam/pull/12656?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/beam/pull/12656?src=pr&el=footer). Last
update
[cfa448d...121db3d](https://codecov.io/gh/apache/beam/pull/12656?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 476406)
Time Spent: 1.5h (was: 1h 20m)
> Allow PTransformOverride to use AppliedPTransform when constructing
> replacement transform
> -----------------------------------------------------------------------------------------
>
> Key: BEAM-10781
> URL: https://issues.apache.org/jira/browse/BEAM-10781
> Project: Beam
> Issue Type: New Feature
> Components: sdk-py-core
> Reporter: Yifan Mai
> Assignee: Yifan Mai
> Priority: P2
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> In the Python SDK, {{PTransformOverride.get_replacement_transform}} takes in
> a
> [{{PTransform}}|https://github.com/apache/beam/blob/cfa448d121297398312d09c531258a72b413488b/sdks/python/apache_beam/pipeline.py#L1321]
> rather than an {{AppliedPTransform}}. This is inconvenient because the
> {{PTransformOverride}} may want to inspect the properties of the
> {{AppliedPTransform}} when constructing the replacement {{PTransform}}. This
> is already [allowed in
> Java|https://github.com/apache/beam/blob/cfa448d121297398312d09c531258a72b413488b/sdks/java/core/src/main/java/org/apache/beam/sdk/runners/PTransformOverrideFactory.java#L49].
> The proposal to do this in a backward compatible way is as follows:
> * Introduce
> {{PTransformOverride.get_replacement_transform_for_applied_ptransform(self,
> applied_ptransform}} and call it instead of
> {{PTransformOverride.get_replacement_transform}}. The user can override this
> to provide a replacement {{PTransform}} using the input {{AppliedPTransform}}.
> * Provide a default implementation of
> {{PTransformOverride.get_replacement_transform_for_applied_ptransform()}}
> that calls {{PTransformOverride.get_replacement_transform()}} for backwards
> compatibility
> * Deprecate {{PTransformOverride.get_replacement_transform()}}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
