[
https://issues.apache.org/jira/browse/BEAM-6161?focusedWorklogId=187002&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-187002
]
ASF GitHub Bot logged work on BEAM-6161:
----------------------------------------
Author: ASF GitHub Bot
Created on: 18/Jan/19 19:09
Start Date: 18/Jan/19 19:09
Worklog Time Spent: 10m
Work Description: ajamato commented on pull request #7272: [BEAM-6161]
Introduce PCollectionConsumerRegistry and add ElementCoun…
URL: https://github.com/apache/beam/pull/7272#discussion_r249154236
##########
File path:
runners/java-fn-execution/src/test/java/org/apache/beam/runners/fnexecution/control/RemoteExecutionTest.java
##########
@@ -507,13 +508,36 @@ public void testMetrics() throws Exception {
"create",
ParDo.of(
new DoFn<byte[], String>() {
+ private boolean emitted = false;
+
@ProcessElement
public void process(ProcessContext ctxt) {
- Metrics.counter(RemoteExecutionTest.class,
counterMetricName).inc();
+ // Due to a bug impulse is producing two elements
instead of one.
+ // So add this check to only emit these three
elemenets.
Review comment:
I wlll add this, thank you
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 187002)
Time Spent: 9.5h (was: 9h 20m)
> Add ElementCount MonitoringInfos for the Java SDK
> -------------------------------------------------
>
> Key: BEAM-6161
> URL: https://issues.apache.org/jira/browse/BEAM-6161
> Project: Beam
> Issue Type: New Feature
> Components: java-fn-execution, sdk-java-harness
> Reporter: Alex Amato
> Assignee: Alex Amato
> Priority: Major
> Time Spent: 9.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
