[
https://issues.apache.org/jira/browse/BEAM-6470?focusedWorklogId=187710&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-187710
]
ASF GitHub Bot logged work on BEAM-6470:
----------------------------------------
Author: ASF GitHub Bot
Created on: 21/Jan/19 12:09
Start Date: 21/Jan/19 12:09
Worklog Time Spent: 10m
Work Description: robertwb commented on pull request #7577: [BEAM-6470]
Remove dependency on tenacity
URL: https://github.com/apache/beam/pull/7577#discussion_r249426836
##########
File path: sdks/python/apache_beam/runners/portability/fn_api_runner_test.py
##########
@@ -557,7 +555,9 @@ def assert_counter_exists(metrics, namespace, name, step):
# this test is flaky when state duration is low.
# Since increasing state duration significantly would also slow down
# the test suite, we are retrying twice on failure as a mitigation.
- @retry(reraise=True, stop=stop_after_attempt(3))
+ @retry.with_exponential_backoff(num_retries=2, factor=1,
+ initial_delay_secs=0.1, max_delay_secs=0.1,
Review comment:
Hmm... given all this and including the fact that the default retry filter
is http errors, it feels like this is not really the right fit.
Given that this is actually a test, I think simply using test dependencies
make sense here, including tenacity.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 187710)
Time Spent: 1h 50m (was: 1h 40m)
> python tenacity is breaks the Python validates runner flink tests
> -----------------------------------------------------------------
>
> Key: BEAM-6470
> URL: https://issues.apache.org/jira/browse/BEAM-6470
> Project: Beam
> Issue Type: Bug
> Components: test-failures
> Reporter: Ankur Goenka
> Assignee: Ankur Goenka
> Priority: Major
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> Python tenacity is only added for test cases.
> Beam VR tests executes actual pipelines which do not have tenacity.
> We already have apache_beam.util.retry which has the retry functionality so
> replacing tenacity with it will solve this problem.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
