[
https://issues.apache.org/jira/browse/BEAM-10705?focusedWorklogId=481561&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-481561
]
ASF GitHub Bot logged work on BEAM-10705:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 10/Sep/20 16:37
Start Date: 10/Sep/20 16:37
Worklog Time Spent: 10m
Work Description: samatix opened a new pull request #12811:
URL: https://github.com/apache/beam/pull/12811
The fix does the following:
- It extracts and uses the filename when downloading a remote wheel file
(http, https) specified in --sdk_location at the staging phase.
- It refactored the test_sdk_location_remote_wheel as the initial unittest
didn't cover well the remote wheel case
CC: @tvalentyn
Fixes when the --sdk_location
------------------------
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [ x ] [**Choose
reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and
mention them in a comment (`R: @username`).
- [ x ] Format the pull request title like `[BEAM-XXX] Fixes bug in
ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA
issue, if applicable. This will automatically link the pull request to the
issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ NA ] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more
tips on [how to make review process
smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Dataflow | Flink | Samza | Spark | Twister2
--- | --- | --- | --- | --- | --- | ---
Go | [](https://ci-beam.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/)
| --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/)
| --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/)
| ---
Java | [](https://ci-beam.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/)
| [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/)
| [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Java11/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/)
| [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/)
| [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/)
| [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Twister2/lastCompletedBuild/)
Python | [](https://ci-beam.apache.org/job/beam_PostCommit_Python2/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python35/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python38/lastCompletedBuild/)
| [](https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/)
| [](https://ci-beam.apache.org/job/beam_PreCommit_Python2_PVR_Flink_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python35_VR_Flink/lastCompletedBuild/)
| --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Spark/lastCompletedBuild/)
| ---
XLang | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Direct/lastCompletedBuild/)
| --- | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/)
| --- | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/)
| ---
Pre-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
--- |Java | Python | Go | Website | Whitespace | Typescript
--- | --- | --- | --- | --- | --- | ---
Non-portable | [](https://ci-beam.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/)
| [](https://ci-beam.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PreCommit_PythonDocker_Cron/lastCompletedBuild/)
<br>[](https://ci-beam.apache.org/job/beam_PreCommit_PythonDocs_Cron/lastCompletedBuild/)
| [](https://ci-beam.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/)
| [](https://ci-beam.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/)
| [](https://ci-beam.apache.org/job/beam_PreCommit_Whitespace_Cron/lastCompletedBuild/)
| [](https://ci-beam.apache.org/job/beam_PreCommit_Typescript_Cron/lastCompletedBuild/)
Portable | --- | [](https://ci-beam.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/)
| --- | --- | --- | ---
See
[.test-infra/jenkins/README](https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md)
for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more
information about GitHub Actions CI.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 481561)
Remaining Estimate: 0h
Time Spent: 10m
> Passing whl files in --sdk_location does not work for https locations.
> -----------------------------------------------------------------------
>
> Key: BEAM-10705
> URL: https://issues.apache.org/jira/browse/BEAM-10705
> Project: Beam
> Issue Type: Improvement
> Components: sdk-py-core
> Reporter: Valentyn Tymofieiev
> Assignee: Ayoub Ennassiri
> Priority: P3
> Labels: starter
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Sample repro:
> python -m apache_beam.examples.wordcount
> --input=gs://dataflow-samples/shakespeare/kinglear.txt --output
> /tmp/wordcount --runner=DataflowRunner --project=google.com:clo
> uddfe --temp_location gs://clouddfe-valentyn/tmp/ --region=us-central1
> --sdk_location=https://
> storage.googleapis.com/beam-wheels-staging/master/94f9e7fd4cae0f8aa6587d2cf14887f1c4827485-198
> 203585/apache_beam-2.24.0.dev0-cp27-cp27m-macosx_10_9_x86_64.whl
> {noformat}
> File "/home/valentyn/.pyenv/versions/3.7.3/lib/python3.7/runpy.py", line
> 193, in _run_module_as_main
> "__main__", mod_spec)
> File "/home/valentyn/.pyenv/versions/3.7.3/lib/python3.7/runpy.py", line
> 85, in _run_code
> exec(code, run_globals)
> File
> "/home/valentyn/projects/beam/beam2/beam/sdks/python/apache_beam/examples/wordcount.py",
> line 99, in <module>
> run()
> File
> "/home/valentyn/projects/beam/beam2/beam/sdks/python/apache_beam/examples/wordcount.py",
> line 94, in run
> output | 'Write' >> WriteToText(known_args.output)
> File
> "/home/valentyn/projects/beam/beam2/beam/sdks/python/apache_beam/pipeline.py",
> line 555, in __exit__
> self.result = self.run()
> File
> "/home/valentyn/projects/beam/beam2/beam/sdks/python/apache_beam/pipeline.py",
> line 521, in run
> allow_proto_holders=True).run(False)
> File
> "/home/valentyn/projects/beam/beam2/beam/sdks/python/apache_beam/pipeline.py",
> line 534, in run
> return self.runner.run_pipeline(self, self._options)
> File
> "/home/valentyn/projects/beam/beam2/beam/sdks/python/apache_beam/runners/dataflow/dataflow_runner.py",
> line 479, in run_pipeline
> artifacts=environments.python_sdk_dependencies(options)))
> File
> "/home/valentyn/projects/beam/beam2/beam/sdks/python/apache_beam/transforms/environments.py",
> line 613, in python_sdk_dependencies
> staged_name in stager.Stager.create_job_resources(options, tmp_dir))
> File
> "/home/valentyn/projects/beam/beam2/beam/sdks/python/apache_beam/runners/portability/stager.py",
> line 235, in create_job_resources
> resources.extend(Stager._create_beam_sdk(sdk_remote_location, temp_dir))
> File
> "/home/valentyn/projects/beam/beam2/beam/sdks/python/apache_beam/runners/portability/stager.py",
> line 659, in _create_beam_sdk
> sdk_remote_location)
> File
> "/home/valentyn/projects/beam/beam2/beam/sdks/python/apache_beam/runners/portability/stager.py",
> line 596, in _desired_sdk_filename_in_staging_location
> _, wheel_filename = FileSystems.split(sdk_location)
> File
> "/home/valentyn/projects/beam/beam2/beam/sdks/python/apache_beam/io/filesystems.py",
> line 151, in split
> filesystem = FileSystems.get_filesystem(path)
> File
> "/home/valentyn/projects/beam/beam2/beam/sdks/python/apache_beam/io/filesystems.py",
> line 106, in get_filesystem
> 'e.g., pip install apache-beam[gcp]. Path specified: %s' % path)
> ValueError: Unable to get filesystem from specified path, please use the
> correct path or ensure the required dependency is installed, e.g., pip
> install apache-beam[gcp]. Path specified:
> https://storage.googleapis.com/beam-wheels-staging/master/94f9e7fd4cae0f8aa6587d2cf14887f1c4827485-198203585/apache_beam-2.24.0.dev0-cp27-cp27m-macosx_10_9_x86_64.whl
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
