[ https://issues.apache.org/jira/browse/BEAM-10824?focusedWorklogId=481821&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-481821 ]
ASF GitHub Bot logged work on BEAM-10824: ----------------------------------------- Author: ASF GitHub Bot Created on: 11/Sep/20 00:50 Start Date: 11/Sep/20 00:50 Worklog Time Spent: 10m Work Description: tvalentyn commented on pull request #12756: URL: https://github.com/apache/beam/pull/12756#issuecomment-690807589 LGTM, thanks a lot, @monicadsong ! ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 481821) Remaining Estimate: 6h (was: 6h 10m) Time Spent: 18h (was: 17h 50m) > Hash in stats.ApproximateUniqueCombineFn NON-deterministic > ---------------------------------------------------------- > > Key: BEAM-10824 > URL: https://issues.apache.org/jira/browse/BEAM-10824 > Project: Beam > Issue Type: Bug > Components: sdk-py-core > Reporter: Monica Song > Priority: P1 > Labels: hash > Original Estimate: 24h > Time Spent: 18h > Remaining Estimate: 6h > > The python hash() function is non-deterministic. As a result, different > workers will map identical values to different hashes. This leads to > overestimation of the number of unique values (by several magnitudes, in my > experience x1000) in a distributed processing model. > [https://github.com/apache/beam/blob/master/sdks/python/apache_beam/transforms/stats.py#L218] > > -- This message was sent by Atlassian Jira (v8.3.4#803005)