[ https://issues.apache.org/jira/browse/BEAM-6285?focusedWorklogId=188933&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-188933 ]
ASF GitHub Bot logged work on BEAM-6285: ---------------------------------------- Author: ASF GitHub Bot Created on: 23/Jan/19 13:24 Start Date: 23/Jan/19 13:24 Worklog Time Spent: 10m Work Description: XuMingmin commented on pull request #7598: [BEAM-6285] add parameters for offsetConsumer in KafkaIO.read() URL: https://github.com/apache/beam/pull/7598 Set additional parameters for `KafkaUnboundedReader.offsetConsumer`, added by BEAM-6285. In `KafkaIO.read()`, there're two consumers running in the backend actually: 1. `KafkaUnboundedReader.consumer`, which is the main consumer to read data from kafka topic(s); 2. `KafkaUnboundedReader.offsetConsumer`, which is used to estimate backlog, by fetching the latest offset; By default, `KafkaUnboundedReader.offsetConsumer` shares the same parameters with `KafkaUnboundedReader.consumer`, with a generated `ConsumerConfig.GROUP_ID_CONFIG`(value is `%topicname_offset_consumer_%randonNumber_%groupId`). This may not work when the topic is secured in Kafka. In this case with secured topics, you can add specific parameters for `KafkaUnboundedReader.offsetConsumer`, to overwrite parameters for `KafkaUnboundedReader.consumer`. ------------------------ Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). It will help us expedite review of your Pull Request if you tag someone (e.g. `@username`) to look at it. Post-Commit Tests Status (on master branch) ------------------------------------------------------------------------------------------------ Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark --- | --- | --- | --- | --- | --- | --- | --- Go | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | --- | --- | --- | --- | --- Java | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/) Python | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Python_Verify/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Python_Verify/lastCompletedBuild/) | --- | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/) </br> [![Build Status](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | --- | --- | --- | --- ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 188933) Time Spent: 10m Remaining Estimate: 0h > add parameters for offsetConsumer in KafkaIO.read() > --------------------------------------------------- > > Key: BEAM-6285 > URL: https://issues.apache.org/jira/browse/BEAM-6285 > Project: Beam > Issue Type: Improvement > Components: io-java-kafka > Reporter: Xu Mingmin > Assignee: Xu Mingmin > Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > Add an option in KafkaIO.read() to avoid using `offsetConsumer`. > *What's the problem:* > When security is enabled, function > `KafkaUnboundedReader.updateLatestOffsets()` always fails with lots of WARN > log. > *What's the cause:* > `offsetConsumer` uses a mocked `ConsumerConfig.GROUP_ID_CONFIG`, and it > doesn't work as expected when security is enabled. In our case, > `ConsumerConfig.GROUP_ID_CONFIG` is the key to validate whether this consumer > is approved. > *What's the solution:* > Add an option to disable `offsetConsumer` by developers; > *What's the side effect:* > With `offsetConsumer` disabled, backlog is unknown. > > [~rangadi] any comments? > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)