[
https://issues.apache.org/jira/browse/BEAM-6464?focusedWorklogId=189393&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-189393
]
ASF GitHub Bot logged work on BEAM-6464:
----------------------------------------
Author: ASF GitHub Bot
Created on: 24/Jan/19 10:12
Start Date: 24/Jan/19 10:12
Worklog Time Spent: 10m
Work Description: robertwb commented on pull request #7563: [BEAM-6464]
Enable docker environment for SDK workers.
URL: https://github.com/apache/beam/pull/7563#discussion_r250539370
##########
File path: sdks/python/apache_beam/runners/portability/fn_api_runner.py
##########
@@ -813,20 +892,29 @@ def state_api_service_descriptor(self):
return endpoints_pb2.ApiServiceDescriptor(
url='localhost:%s' % self.state_port)
+ def logging_api_service_descriptor(self):
+ return endpoints_pb2.ApiServiceDescriptor(
+ url='localhost:%s' % self.logging_port)
+
def close(self):
self.control_handler.done()
self.data_plane_handler.close()
- self.control_server.stop(5).wait()
- self.data_server.stop(5).wait()
- self.state_server.stop(5).wait()
+ to_wait = [
+ self.control_server.stop(5),
+ self.data_server.stop(5),
+ self.state_server.stop(5),
+ self.logging_server.stop(5)
Review comment:
Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 189393)
Time Spent: 2h 10m (was: 2h)
> PortableRunner should run dockerized SDK workers
> ------------------------------------------------
>
> Key: BEAM-6464
> URL: https://issues.apache.org/jira/browse/BEAM-6464
> Project: Beam
> Issue Type: New Feature
> Components: sdk-py-core
> Reporter: Robert Bradshaw
> Assignee: Ahmet Altay
> Priority: Major
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> These can be controlled by the environment variable.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
