[ https://issues.apache.org/jira/browse/BEAM-6161?focusedWorklogId=189776&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-189776 ]
ASF GitHub Bot logged work on BEAM-6161: ---------------------------------------- Author: ASF GitHub Bot Created on: 25/Jan/19 00:21 Start Date: 25/Jan/19 00:21 Worklog Time Spent: 10m Work Description: ryan-williams commented on pull request #7272: [BEAM-6161] Introduce PCollectionConsumerRegistry and add ElementCoun… URL: https://github.com/apache/beam/pull/7272#discussion_r250827912 ########## File path: runners/core-java/src/main/java/org/apache/beam/runners/core/metrics/SpecMonitoringInfoValidator.java ########## @@ -68,6 +68,7 @@ public SpecMonitoringInfoValidator() { monitoringInfo.getUrn(), spec.getTypeUrn(), monitoringInfo.getType())); } + // TODO(ajamato): Tighten this restriction to use set equality, to catch unused Review comment: Just noting: I recently had a local change to keep this a bit relaxed, because I was testing with user metrics that were getting a `PTRANSFORM` label. I'd weakened the condition below to: ```java !requiredLabels.ieEmpty && !monitoringInfo.getLabelsMap().keySet().equals(requiredLabels) ``` where previously it required strict equality in all cases. Seemingly this was relaxed to the `containsAll` below before I got anywhere with my change, and it's possible I was in some other invalid state to have had user metrics with a `PTRANSFORM` label that were failing the strict test (where `requiredLabels` was empty). Just wanted to leave a breadcrumb here about that since we'll probably come back to it soon.. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 189776) Time Spent: 11.5h (was: 11h 20m) > Add ElementCount MonitoringInfos for the Java SDK > ------------------------------------------------- > > Key: BEAM-6161 > URL: https://issues.apache.org/jira/browse/BEAM-6161 > Project: Beam > Issue Type: New Feature > Components: java-fn-execution, sdk-java-harness > Reporter: Alex Amato > Assignee: Alex Amato > Priority: Major > Time Spent: 11.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.3#76005)