[
https://issues.apache.org/jira/browse/BEAM-10527?focusedWorklogId=496110&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-496110
]
ASF GitHub Bot logged work on BEAM-10527:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 06/Oct/20 18:57
Start Date: 06/Oct/20 18:57
Worklog Time Spent: 10m
Work Description: ibzib commented on a change in pull request #13019:
URL: https://github.com/apache/beam/pull/13019#discussion_r500527061
##########
File path: sdks/python/apache_beam/runners/portability/flink_runner_test.py
##########
@@ -56,10 +56,9 @@
# Run as
#
-# pytest flink_runner_test.py \
-# [--test_pipeline_options "--flink_job_server_jar=/path/to/job_server.jar
\
-# --environment_type=DOCKER"] \
-# [FlinkRunnerTest.test_method, ...]
+# pytest flink_runner_test.py[::TestClass::test_case] \
+# --test-pipeline-options "--flink_job_server_jar=/path/to/job_server.jar \
Review comment:
Including --flink_job_server_jar in the usage may be confusing, since it
might not be obvious where the jar can be found. But if --flink_job_server_jar
is omitted, it will be located automatically. Also, --environment_type=DOCKER
requires the Python SDK harness container to be built. Can we either change the
example, or add another, simpler example?
```
# pytest flink_runner_test.py[::TestClass::test_case] \
# --test-pipeline-options "--environment_type=LOOPBACK"
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 496110)
Time Spent: 6.5h (was: 6h 20m)
> Python2_PVR_Flink precommit should publish test results to Jenkins
> ------------------------------------------------------------------
>
> Key: BEAM-10527
> URL: https://issues.apache.org/jira/browse/BEAM-10527
> Project: Beam
> Issue Type: Improvement
> Components: testing
> Reporter: Kyle Weaver
> Assignee: Kyle Weaver
> Priority: P2
> Fix For: Not applicable
>
> Time Spent: 6.5h
> Remaining Estimate: 0h
>
> Right now we only have the logs, which often require scrolling up to see the
> failure (which itself often requires curl'ing the logs because they are too
> large for a browser to load comfortably). This causes frequent
> misunderstandings. For example, folks often mistake errors printed by
> pipelines that are meant to fail (e.g. test_error_message_includes_stage) for
> actual test failures.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
