[
https://issues.apache.org/jira/browse/BEAM-3736?focusedWorklogId=497259&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-497259
]
ASF GitHub Bot logged work on BEAM-3736:
----------------------------------------
Author: ASF GitHub Bot
Created on: 08/Oct/20 11:47
Start Date: 08/Oct/20 11:47
Worklog Time Spent: 10m
Work Description: codecov[bot] commented on pull request #13048:
URL: https://github.com/apache/beam/pull/13048#issuecomment-705515661
# [Codecov](https://codecov.io/gh/apache/beam/pull/13048?src=pr&el=h1) Report
> Merging
[#13048](https://codecov.io/gh/apache/beam/pull/13048?src=pr&el=desc) into
[master](https://codecov.io/gh/apache/beam/commit/6bf56f92b34f7c15b752c46eca19489a604c4775?el=desc)
will **decrease** coverage by `0.00%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/beam/pull/13048?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13048 +/- ##
==========================================
- Coverage 82.51% 82.50% -0.01%
==========================================
Files 455 455
Lines 54867 54910 +43
==========================================
+ Hits 45272 45304 +32
- Misses 9595 9606 +11
```
| [Impacted
Files](https://codecov.io/gh/apache/beam/pull/13048?src=pr&el=tree) | Coverage
Δ | |
|---|---|---|
|
[...on/apache\_beam/runners/direct/helper\_transforms.py](https://codecov.io/gh/apache/beam/pull/13048/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kaXJlY3QvaGVscGVyX3RyYW5zZm9ybXMucHk=)
| `98.38% <100.00%> (+0.23%)` | :arrow_up: |
|
[...ks/python/apache\_beam/runners/worker/operations.py](https://codecov.io/gh/apache/beam/pull/13048/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvb3BlcmF0aW9ucy5weQ==)
| `70.39% <100.00%> (+1.05%)` | :arrow_up: |
|
[sdks/python/apache\_beam/transforms/core.py](https://codecov.io/gh/apache/beam/pull/13048/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy9jb3JlLnB5)
| `88.73% <100.00%> (+0.10%)` | :arrow_up: |
|
[sdks/python/apache\_beam/io/source\_test\_utils.py](https://codecov.io/gh/apache/beam/pull/13048/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vc291cmNlX3Rlc3RfdXRpbHMucHk=)
| `88.28% <0.00%> (-1.36%)` | :arrow_down: |
|
[...ks/python/apache\_beam/runners/worker/data\_plane.py](https://codecov.io/gh/apache/beam/pull/13048/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvZGF0YV9wbGFuZS5weQ==)
| `88.32% <0.00%> (-1.20%)` | :arrow_down: |
|
[sdks/python/apache\_beam/io/gcp/bigquery\_tools.py](https://codecov.io/gh/apache/beam/pull/13048/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL2JpZ3F1ZXJ5X3Rvb2xzLnB5)
| `87.79% <0.00%> (-0.57%)` | :arrow_down: |
|
[...nners/portability/fn\_api\_runner/worker\_handlers.py](https://codecov.io/gh/apache/beam/pull/13048/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL3dvcmtlcl9oYW5kbGVycy5weQ==)
| `80.57% <0.00%> (-0.18%)` | :arrow_down: |
|
[sdks/python/apache\_beam/utils/interactive\_utils.py](https://codecov.io/gh/apache/beam/pull/13048/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvaW50ZXJhY3RpdmVfdXRpbHMucHk=)
| `95.23% <0.00%> (+2.38%)` | :arrow_up: |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/beam/pull/13048?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/beam/pull/13048?src=pr&el=footer). Last
update
[6bf56f9...a0d436a](https://codecov.io/gh/apache/beam/pull/13048?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 497259)
Time Spent: 50m (was: 40m)
> Add SetUp() and TearDown() for CombineFns
> -----------------------------------------
>
> Key: BEAM-3736
> URL: https://issues.apache.org/jira/browse/BEAM-3736
> Project: Beam
> Issue Type: Improvement
> Components: beam-model, sdk-py-core
> Reporter: Chuan Yu Foo
> Assignee: Kamil Wasilewski
> Priority: P3
> Time Spent: 50m
> Remaining Estimate: 0h
>
> I have a CombineFn that has a large amount of state that needs to be loaded
> once before it can add_input or merge_combiners (for example, the CombineFn
> might load up a large lookup table used for combining).
> Right now, to initialise this state, for each of the methods, I check if the
> state has already been initialised, and if not, I initialise it. It would be
> nice if CombineFn provided a SetUp() method that is called once to initialise
> this state (and a corresponding TearDown() method to clean up this state if
> necessary).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
