[
https://issues.apache.org/jira/browse/BEAM-11067?focusedWorklogId=500850&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-500850
]
ASF GitHub Bot logged work on BEAM-11067:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 14/Oct/20 21:02
Start Date: 14/Oct/20 21:02
Worklog Time Spent: 10m
Work Description: alanmyrvold opened a new pull request #13117:
URL: https://github.com/apache/beam/pull/13117
License script was not pulling source for license names that were spelled
out. LGPL/MPL worked, but "GNU Lesser Public License" and "Mozzilla Public
License" were not matched.
This uncovered an issue with module names with upper case characters; fixed
by not forcing lower case.
Added logging.
R: @emilymye
R: @Hannah-Jiang
R: @robinyqiu
------------------------
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [ ] [**Choose
reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and
mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in
ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA
issue, if applicable. This will automatically link the pull request to the
issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more
tips on [how to make review process
smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Dataflow | Flink | Samza | Spark | Twister2
--- | --- | --- | --- | --- | --- | ---
Go | [](https://ci-beam.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/)
| --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/)
| --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/)
| ---
Java | [](https://ci-beam.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/)
| [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/)
| [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Java11/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/)
| [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/)
| [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/)
| [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Twister2/lastCompletedBuild/)
Python | [](https://ci-beam.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python38/lastCompletedBuild/)
| [](https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/)
| [](https://ci-beam.apache.org/job/beam_PreCommit_Python_PVR_Flink_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Flink/lastCompletedBuild/)
| --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Spark/lastCompletedBuild/)
| ---
XLang | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Direct/lastCompletedBuild/)
| --- | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/)
| --- | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/)
| ---
Pre-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
--- |Java | Python | Go | Website | Whitespace | Typescript
--- | --- | --- | --- | --- | --- | ---
Non-portable | [](https://ci-beam.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/)
| [](https://ci-beam.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PreCommit_PythonDocker_Cron/lastCompletedBuild/)
<br>[](https://ci-beam.apache.org/job/beam_PreCommit_PythonDocs_Cron/lastCompletedBuild/)
| [](https://ci-beam.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/)
| [](https://ci-beam.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/)
| [](https://ci-beam.apache.org/job/beam_PreCommit_Whitespace_Cron/lastCompletedBuild/)
| [](https://ci-beam.apache.org/job/beam_PreCommit_Typescript_Cron/lastCompletedBuild/)
Portable | --- | [](https://ci-beam.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/)
| --- | --- | --- | ---
See
[.test-infra/jenkins/README](https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md)
for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more
information about GitHub Actions CI.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 500850)
Remaining Estimate: 0h
Time Spent: 10m
> Source not included on Java SDK docker image for some GPL/LGPL/MPL
> dependencies, like saxon-he and jformatstring
> ----------------------------------------------------------------------------------------------------------------
>
> Key: BEAM-11067
> URL: https://issues.apache.org/jira/browse/BEAM-11067
> Project: Beam
> Issue Type: Bug
> Components: build-system
> Affects Versions: 2.25.0
> Reporter: Alan Myrvold
> Assignee: Alan Myrvold
> Priority: P1
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The java sdk docker image attempts to include source for GPL/LGPL/MPL/CDDL
> dependencies, but misses several.
> ./gradlew -Pdocker-pull-licenses :sdks:java:container:docker --info
> the problem seems to be in the check for the license type:
> [https://github.com/alanmyrvold/beam/blob/c921b0c8384809dbcab3edcd5007e92da25067c6/sdks/java/container/license_scripts/pull_licenses_java.py#L41]
> SOURCE_CODE_REQUIRED_LICENSES = ['lgpl', 'glp', 'cddl', 'mpl']
> Some of the license types in the beam_java_dependency_list.csv.gz spell out
> the license name, like "GNU Lesser" and don't match.
> spotbugs-4.0.6,https://www.gnu.org/licenses/old-licenses/lgpl-2.1.en.html,"GNU
> LESSER GENERAL PUBLIC LICENSE, Version 2.1",False
> jformatstring-3.0.0,http://www.gnu.org/licenses/lgpl.html,GNU Lesser Public
> License,False
> spotbugs-annotations-4.0.6,https://www.gnu.org/licenses/old-licenses/lgpl-2.1.en.html,"GNU
> LESSER GENERAL PUBLIC LICENSE, Version 2.1",False
> saxon-he-9.9.1-2,http://www.mozilla.org/MPL/2.0/,Mozilla Public License
> Version 2.0,False
> saxon-he-9.9.1-4,http://www.mozilla.org/MPL/2.0/,Mozilla Public License
> Version 2.0,False
> checkstyle-8.23,http://www.gnu.org/licenses/old-licenses/lgpl-2.1.txt,LGPL-2.1+,True
> javassist-3.24.0-GA,http://www.mozilla.org/MPL/MPL-1.1.html,MPL 1.1,True
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
