[
https://issues.apache.org/jira/browse/BEAM-5442?focusedWorklogId=191005&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-191005
]
ASF GitHub Bot logged work on BEAM-5442:
----------------------------------------
Author: ASF GitHub Bot
Created on: 28/Jan/19 14:12
Start Date: 28/Jan/19 14:12
Worklog Time Spent: 10m
Work Description: mxm commented on pull request #7597: [BEAM-5442]
Retrieve valid runner options from JobService
URL: https://github.com/apache/beam/pull/7597#discussion_r251429532
##########
File path: sdks/python/apache_beam/runners/portability/flink_runner_test.py
##########
@@ -129,8 +128,8 @@ def get_runner(cls):
def create_options(self):
options = super(FlinkRunnerTest, self).create_options()
options.view_as(DebugOptions).experiments = ['beam_fn_api']
- options.view_as(FlinkOptions).parallelism = 1
- options.view_as(FlinkOptions).shutdown_sources_on_final_watermark = True
+ options._all_options['parallelism'] = 1
+ options._all_options['shutdown_sources_on_final_watermark'] = True
Review comment:
Command-line options are one way, another is to use the options provided by
the SDK. It would be helpful to at least know that Flink options exist, even if
they are provided by the Runner at runtime. I feel like this is where the new
approach falls a bit short. Just something to think about.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 191005)
Time Spent: 19.5h (was: 19h 20m)
> PortableRunner swallows custom options for Runner
> -------------------------------------------------
>
> Key: BEAM-5442
> URL: https://issues.apache.org/jira/browse/BEAM-5442
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core, sdk-py-core
> Reporter: Maximilian Michels
> Assignee: Thomas Weise
> Priority: Major
> Labels: portability, portability-flink
> Time Spent: 19.5h
> Remaining Estimate: 0h
>
> The PortableRunner doesn't pass custom PipelineOptions to the executing
> Runner.
> Example: {{--parallelism=4}} won't be forwarded to the FlinkRunner.
> (The option is just removed during proto translation without any warning)
> We should allow some form of customization through the options, even for the
> PortableRunner.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
