[
https://issues.apache.org/jira/browse/BEAM-5442?focusedWorklogId=191044&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-191044
]
ASF GitHub Bot logged work on BEAM-5442:
----------------------------------------
Author: ASF GitHub Bot
Created on: 28/Jan/19 14:49
Start Date: 28/Jan/19 14:49
Worklog Time Spent: 10m
Work Description: mxm commented on pull request #7597: [BEAM-5442]
Retrieve valid runner options from JobService
URL: https://github.com/apache/beam/pull/7597#discussion_r251445307
##########
File path:
sdks/java/core/src/test/java/org/apache/beam/sdk/options/PipelineOptionsFactoryTest.java
##########
@@ -2049,4 +2055,85 @@ static String myStaticMethod(OptionsWithStaticMethod o)
{
return o.getMyMethod();
}
}
+
+ /** Test interface. */
+ public interface TestDescribeOptions extends PipelineOptions {
+ String getString();
+
+ void setString(String value);
+
+ @Description("integer property")
+ Integer getInteger();
+
+ void setInteger(Integer value);
+
+ @Description("float number property")
+ Float getFloat();
+
+ void setFloat(Float value);
+
+ @Description("simple boolean property")
+ @Default.Boolean(true)
+ boolean getBooleanSimple();
+
+ void setBooleanSimple(boolean value);
+
+ @Default.Boolean(false)
+ Boolean getBooleanWrapper();
+
+ void setBooleanWrapper(Boolean value);
+
+ List<Integer> getList();
+
+ void setList(List<Integer> value);
+ }
+
+ @Test
+ public void testDescribe() {
+ List<PipelineOptionDescriptor> described =
+
PipelineOptionsFactory.describe(Sets.newHashSet(TestDescribeOptions.class));
+ Collection<PipelineOptionDescriptor> filtered =
+ Collections2.filter(
+ described, input ->
input.getGroup().equals(TestDescribeOptions.class.getName()));
+ assertEquals(6, filtered.size());
+ Map<String, PipelineOptionDescriptor> mapped =
+
org.apache.beam.vendor.guava.v20_0.com.google.common.collect.Maps.uniqueIndex(
Review comment:
Fine to keep as-is, or import `uniqueIndex`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 191044)
Time Spent: 21h 40m (was: 21.5h)
> PortableRunner swallows custom options for Runner
> -------------------------------------------------
>
> Key: BEAM-5442
> URL: https://issues.apache.org/jira/browse/BEAM-5442
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core, sdk-py-core
> Reporter: Maximilian Michels
> Assignee: Thomas Weise
> Priority: Major
> Labels: portability, portability-flink
> Time Spent: 21h 40m
> Remaining Estimate: 0h
>
> The PortableRunner doesn't pass custom PipelineOptions to the executing
> Runner.
> Example: {{--parallelism=4}} won't be forwarded to the FlinkRunner.
> (The option is just removed during proto translation without any warning)
> We should allow some form of customization through the options, even for the
> PortableRunner.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
